Fix asm sym operand parsing for parenthesized expr fragments #21588
+54
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21582
Summary
When capturing a path via
$e:expr, macro expansion treats it asFragment::Exprand wraps it in parentheses to preserve operator precedence.This results in
sym (generic::<i32>), but the existing parser expected a path immediately aftersymand failed when seeing(, leading to a parse failure and a bogus typed-hole diagnostic.Changes
symas an expressionWhy this approach
This keeps parsing more permissive while keeping the semantic requirement (“
symexpects a path”) enforced during lowering.Testing
symoperand causes parsing errors #21582cargo test(and any focused test targets you ran)AI Usage
AI disclosure:
I used ChatGPT to help draft the PR description and clarify the root-cause explanation.
The implementation and tests were written and validated by me.