fix: rename schema subItems with sub_items#22444
Open
A4-Tacks wants to merge 1 commit into
Open
Conversation
rustbot
added
the
S-waiting-on-review
lnicola
approved these changes
May 25, 2026
Member
|
Hmm, I always write subitem, not sub-item, as if it's a single word. |
Member
Author
|
Or change the renaming config of serde?
However, considering that it has already been released, it may be necessary to consider breaking |
Contributor
|
It is a breaking change (although the breakage is minimal). If we had come up with this initially, fine, but now, I don't think it's worth the breakage. |
Member
|
I wouldn't be that worried about the breaking change, most users didn't even update yet. There are more people who win the lottery than those who might be affected by this. |
Contributor
|
True, on the other hand I wouldn't be worried about this change either. If it was something clearly better, maybe. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixup #22416