Skip to content

fix: generate method on generic type now includes impl generics#22450

Open
Albab-Hasan wants to merge 2 commits into
rust-lang:masterfrom
Albab-Hasan:generate-method-impl-generics
Open

fix: generate method on generic type now includes impl generics#22450
Albab-Hasan wants to merge 2 commits into
rust-lang:masterfrom
Albab-Hasan:generate-method-impl-generics

Conversation

@Albab-Hasan
Copy link
Copy Markdown
Contributor

@Albab-Hasan Albab-Hasan commented May 25, 2026

fixes #19806

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 25, 2026
ChayimFriedman2
ChayimFriedman2 requested changes May 25, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@ChayimFriedman2 ChayimFriedman2 left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't just copy the GenericParamList and WhereClause from the ADT which can be in a different module. You need to apply PathTransform over it.

View changes since this review

@Albab-Hasan
Copy link
Copy Markdown
Contributor Author

Albab-Hasan commented May 26, 2026

@ChayimFriedman2 done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChayimFriedman2 ChayimFriedman2 ChayimFriedman2 requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Generate method assist misses generics when generating an impl block

3 participants

@Albab-Hasan @ChayimFriedman2 @rustbot