Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions crates/ide-diagnostics/src/handlers/type_mismatch.rs
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,22 @@ fn add_or_fix_reference(
return None;
}

let expr = expr_ptr.to_node(ctx.db());
let assign = expr
.syntax()
.parent()
.and_then(ast::BinExpr::cast)
.filter(|it| it.op_kind() == Some(ast::BinaryOp::Assignment { op: None }));
if let Some(assign) = assign
&& expected_mutability.is_mut()
&& let Some(range) = ctx.sema.original_range_opt(assign.syntax())
{
let edit = TextEdit::insert(range.range.start(), "*".to_owned());
let source_change = SourceChange::from_text_edit(range.file_id.file_id(ctx.db()), edit);
acc.push(fix("add_deref_here", "Add deref here", source_change, range.range));
return Some(());
}

let ampersands = format!("&{}", expected_mutability.as_keyword_for_ref());

let edit = TextEdit::insert(range.range.start(), ampersands);
Expand Down Expand Up @@ -507,6 +523,22 @@ fn test(_arg: &mut i32) {}
);
}

#[test]
fn add_deref_in_assign() {
check_fix(
r#"
fn test(arg: &mut i32) {
arg = $02;
}
"#,
r#"
fn test(arg: &mut i32) {
*arg = 2;
}
"#,
);
}

#[test]
fn add_reference_to_array() {
check_fix(
Expand Down
Loading