feat: Hide private fields on hover depending on context#22464
Open
Veykril wants to merge 1 commit into
Open
Conversation
44f1bcf to
2e29ddd
Compare
Contributor
|
FWIW I do find private fields useful but as long as it's configurable I don't object (even if it's off by default). |
Member
Author
|
I am curious about that thought, I think I was of the same opinion before but at this point I've kind of changed my mind. If its a private field in a dep I don't really see how it would be useful in the common case to see since it wont ever be possible for me to change that. And in the very rare case where it is interesting to then see one could always go to def. Hence this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hides private fields as follows