Add 'db to NavigationTarget and beyond#22470
Open
ada4a wants to merge 14 commits into
Open
Conversation
Note: this will not compile due to the queries in `ide`
…vigationTarget<'static>`
rustbot
added
the
S-waiting-on-review
Member
|
Hm, yea I am not sure we can even return these ever with a 'db lifetime. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses the FIXME on
rust-analyzer/crates/ide/src/navigation_target.rs
Lines 53 to 54 in b48cc10
(cc @ChayimFriedman2 since you were the one who added it)
To be completely honest, I'm not sure if this is worth it, since
NavigationTargetends up appearing inside of a lot of structs which in turn are returned by queries inlsp, requiring all of them to be turned into their'staticversions anyway. One could argue that all the remaining uses ofNavigationTargetbenefit from this change, though it's unclear how many of those there are.