remove clone subtree from ide-ssr#22485
Open
Shourya742 wants to merge 1 commit into
Open
Conversation
rustbot
added
the
S-waiting-on-review
Member
Author
|
For some reason, I don’t like how we handle template replacement in SSR. We could have done this cleanly using just make. The only reason we construct a string and then parse it back is because make cannot work directly with a string. All of this should instead be built from AST bits and pieces rather than relying on string-parsing shenanigans. |
Shourya742
force-pushed
the
2026-05-29-remove-clone-subtree-from-ide-ssr
branch
from
dd87932 to
4f0c28a
Compare
Shourya742
force-pushed
the
2026-05-29-remove-clone-subtree-from-ide-ssr
branch
from
4f0c28a to
0dfc9a4
Compare
Shourya742
force-pushed
the
2026-05-29-remove-clone-subtree-from-ide-ssr
branch
from
0dfc9a4 to
48b851f
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #15710 and #18285