Re-enable CI cache#22496
Conversation
3ab1704 to
0b2c535
Compare
|
What is the expected speed increase? If it doesn't turn CI into "immediate", and there aren't other reasons to have a cache (save compute for the Project etc.), I don't think this is worth it. Having to deal with caches in CI can be not fun, and 10 minutes is not a lot (r-l/r CI is some hours - that is too long). |
|
Lukas wrote that CI times are atrocious, so I suppose that it depends on the perceived speed 😆 My goal would be to get all workflows, say, under 2 minutes, so that there isn't any large bottleneck standing out. From my experience, the difference in CI time between 2 minutes and 6-8 minutes is quite large. Not sure if we can get down to 2 minutes though. |
|
Maybe it depends on the workflow. I do not depend on CI usually, I run on checks locally (test+Clippy, of course not on all platforms but it's usually enough), unless I have a strong reason to believe I'm doing something simple that will succeed), then publish the PR and turn around to do something else. After some time I check back on the PR. |
c0fa6a9 to
7c04e1f
Compare
Proposed in https://rust-lang.zulipchat.com/#narrow/channel/185405-t-compiler.2Frust-analyzer/topic/Moving.20off.20merge.20queue.20to.20new.20bors.3F/with/598734807.
It should now actually work, because CI was switched to run also on the
masterbranch. Thecoverageworkflow seemed to be quite slow (~5 minutes), so I also enabled therust-cacheaction for it; the workflow was already running on pushes tomaster.I removed two commented (previous) usages of
rust-cache, because the corresponding jobs seem to be quite fast these days (<1m).I pinned the version to Swatinem/rust-cache@c193711, which is the latest released version of rust-cache as of today,
2.9.1.