Parse unnamed enum variants#22512
Open
kupiakos wants to merge 1 commit into
Open
Conversation
As of writing, this is still rejected by rustc at a later stage.
rustbot
added
the
S-waiting-on-review
Collaborator
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ChayimFriedman2 (or someone else) some time within the next two weeks. |
Contributor
|
As I commented in the rustc PR, I don't want to merge this PR until the rustc PR is merged. So instead remove the r-a changes from the rustc PR. |
Author
|
@rustbot blocked Until the rustc PR rust-lang/rust#157274 is merged. |
rustbot
added
S-blocked
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the rust-analyzer component of parsing the syntax for the unnamed enum variants lang experiment, tracking issue rust-lang/rust#156628.
As of writing, an enum variant declaration with an underscore for its name is still rejected by rustc at a later stage when including this change.
Once this merges and is pushed over to the rustc repo, I'll rebase rust-lang/rust#157274 so it includes these changes and is feature-gated.
r? ChayimFriedman2