Make bare underscore token an Ident rather than Punct in proc-macro#8122
Merged
bors[bot] merged 2 commits intorust-lang:masterfrom Mar 21, 2021
Merged
Make bare underscore token an Ident rather than Punct in proc-macro#8122bors[bot] merged 2 commits intorust-lang:masterfrom
bors[bot] merged 2 commits intorust-lang:masterfrom
Conversation
edwin0cheng
reviewed
Mar 20, 2021
Contributor
edwin0cheng
left a comment
There was a problem hiding this comment.
LGTM , just a little nit
Contributor
|
Thanks ! bors r+ |
Contributor
Member
|
changelog fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In rustc and proc-macro2, a bare
_token is parsed for procedural macro purposes asIdentrather thanPunct(see rust-lang/rust#48842). This changes rust-analyzer to match rustc's behavior and implementation by handling_as an Ident in token trees, but explicitly preventing$x:identfrom matching it in MBE.proc macro crate:
test crate:
output (rustc):
output (rust-analyzer before this change):
output (rust-analyzer after this change):