Fix two more “a”/“an” typos (this time the other way)#9989
Merged
bors[bot] merged 2 commits intorust-lang:masterfrom Aug 22, 2021
steffahn:a_an
Merged
Fix two more “a”/“an” typos (this time the other way)#9989bors[bot] merged 2 commits intorust-lang:masterfrom steffahn:a_an
bors[bot] merged 2 commits intorust-lang:masterfrom
steffahn:a_an
Conversation
Member
|
You can mark PRs as draft 😛. |
Member
Author
|
Well, each PR by itself is not leaving the source in an unfinished / intermediate state, so I guess it’s not a draft. Also I’m always done until I come up with a new pattern I haven’t searched for… Maybe this was the last commit, though? 🤔 (for now at least…) |
Member
|
Feel free to merge this when you think you are done then 😄 |
Contributor
|
✌️ steffahn can now approve this pull request. To approve and merge a pull request, simply reply with |
Member
Author
|
I really am done for now, as far as I’m aware xD |
Member
|
bors r+ |
Contributor
m-ou-se
added a commit
to m-ou-se/rust
that referenced
this pull request
Aug 23, 2021
Fix typos “a”→“an” Fix typos in comments; found using a regex to find some easy instance of incorrect usage of a vs. an. While automation was used to find these, every change was checked manually. Changes in submodules get separate PRs: * rust-lang/stdarch#1201 * rust-lang/cargo#9821 * rust-lang/miri#1874 * rust-lang/rls#1746 * rust-lang/rust-analyzer#9984 _folks @ rust-analyzer are fast at merging…_ * rust-lang/rust-analyzer#9985 * rust-lang/rust-analyzer#9987 * rust-lang/rust-analyzer#9989 _For `clippy`, I don’t know if the changes should better better be moved to a PR to the original repo._ <hr> This has some overlap with rust-lang#88226, but neither is a strict superset of the other. If you want multiple commits, I can split it up; in that case, make sure to suggest a criterion for splitting.
flip1995
pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
Aug 26, 2021
Fix typos “a”→“an” Fix typos in comments; found using a regex to find some easy instance of incorrect usage of a vs. an. While automation was used to find these, every change was checked manually. Changes in submodules get separate PRs: * rust-lang/stdarch#1201 * rust-lang/cargo#9821 * rust-lang/miri#1874 * rust-lang/rls#1746 * rust-lang/rust-analyzer#9984 _folks @ rust-analyzer are fast at merging…_ * rust-lang/rust-analyzer#9985 * rust-lang/rust-analyzer#9987 * rust-lang/rust-analyzer#9989 _For `clippy`, I don’t know if the changes should better better be moved to a PR to the original repo._ <hr> This has some overlap with #88226, but neither is a strict superset of the other. If you want multiple commits, I can split it up; in that case, make sure to suggest a criterion for splitting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #9987
you guys are still merging these fast 😅
this time I thought – for sure – that I’d get this commit into #9987 before it’s merged…