Allow marking individual global bitfield enums #3342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While it's possible to use `default_enum_style` to get bitfield global enums, this implements bitfield operations for all default enums. This new option allows creating global bitfield enums on a per-type basis similar to the behaviour of `newtype_global_enum`.
Author
|
Checking the CI test results:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it's possible to use
default_enum_styleto get bitfield global enums, this implements bitfield operations for all default enums.This new option allows creating global bitfield enums on a per-type basis similar to the behaviour of
newtype_global_enum.As a workaround, in the Flipper Zero Rust crate we currently implement bitfield operations by hand. It would be nice if this could be done using through bindgen configuration.