implemented lint unnecessary_min by FelixMaetzler · Pull Request #11951 · rust-lang/rust-clippy

FelixMaetzler · 2023-12-11T10:26:50Z

fixes #11924

Please write a short comment explaining your change (or "none" for internal only changes)

changelog: [`unnecessary_min`]: added lint

rustbot · 2023-12-11T10:26:55Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Alexendoo (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

@rustbot author: the review is finished, PR author should check the comments and take action accordingly
@rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

FelixMaetzler · 2023-12-11T10:30:17Z

Hi, this is my first PR ever so please give me feedback if i did something wrong.
I saw that in the naming conventions is written that such a lint should be named unused but in this case i think unnecessary should fit better.
But i can change it if necessary.

tests/ui/unnecessary_min.rs

Co-authored-by: Marti Raudsepp <marti@juffo.org>

clippy_lints/src/methods/mod.rs

clippy_lints/src/methods/unnecessary_min.rs

Alexendoo · 2023-12-13T17:37:23Z

clippy_lints/src/methods/unnecessary_min.rs

+    let cv = constant(cx, cx.typeck_results(), expr)?;
+
+    match (ty.kind(), cv) {


Can use https://doc.rust-lang.org/nightly/nightly-rustc/clippy_utils/consts/enum.Constant.html#method.int_value here

Oh i didnt know this method existed.
I will look into that.
Thank you!

I'm not sure how to implement that change.
I need to use the ty.kind() because i have to know how many bits the integer has.
If i use your proposal, than i only know if it is signed or unsigned and i can't use the math in the arms because it gives me a i128 if it is signed. (unsext wants u128)
Do i miss or misunderstand something here?
Thank you for your feedback. I appreciate it.

bors · 2023-12-16T23:56:09Z

☔ The latest upstream changes (presumably #11977) made this pull request unmergeable. Please resolve the merge conflicts.

rustbot · 2023-12-17T19:39:21Z

There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.

You can start a rebase with the following commands:

$ # rebase
$ git rebase -i master
$ # delete any merge commits in the editor that appears
$ git push --force-with-lease

The following commits are merge commits:

eabe0d5

FelixMaetzler · 2023-12-17T19:58:41Z

i tried the rebase commands as stated above but nothing happens. I get the message: Everything is up-to-date.
Can somebody please help me with what i have to do, to make it happen?

FelixMaetzler · 2023-12-17T20:05:22Z

@rustbot ready

bors · 2023-12-26T15:57:55Z

☔ The latest upstream changes (presumably #12004) made this pull request unmergeable. Please resolve the merge conflicts.

rustbot · 2023-12-29T08:33:00Z

There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.

You can start a rebase with the following commands:

$ # rebase
$ git rebase -i master
$ # delete any merge commits in the editor that appears
$ git push --force-with-lease

The following commits are merge commits (since this message was last posted):

599ed9e

Adds a pair of lints that check for cases of an iterator over `Result` and `Option` followed by `filter` without being followed by `map` as that is covered already by a different, specialized lint. changelog: New Lint: [`iter_filter_is_some`] changelog: New Lint: [`iter_filter_is_ok`]

rustbot · 2023-12-29T08:58:18Z

There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.

You can start a rebase with the following commands:

$ # rebase
$ git rebase -i master
$ # delete any merge commits in the editor that appears
$ git push --force-with-lease

The following commits are merge commits (since this message was last posted):

35ba1eb

FelixMaetzler · 2023-12-29T09:06:16Z

can somebody please help me?
i think i broke stuff.
I tried the things which i was asked for but i don't think, that i did it right.
I'm Sorry

cocodery · 2023-12-30T07:01:55Z

You can try git reset --soft master locally,
sync master branch on github and then pull and merge to this branch,
last, commit your change will be fine.

You can checkout -b a new branch try first, I usually use this method to avoid confict.

rustbot · 2023-12-30T13:39:48Z

There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.

You can start a rebase with the following commands:

$ # rebase
$ git rebase -i master
$ # delete any merge commits in the editor that appears
$ git push --force-with-lease

The following commits are merge commits (since this message was last posted):

c1b19e0

FelixMaetzler · 2023-12-30T14:32:30Z

i tried it but i didnt figure it out.
Now i did a new PR #12061 and hope that that works

FelixMaetzler added 7 commits December 4, 2023 13:11

works for 0 and unsigned ints

980ace1

lint works if both are known at compiletime

6db10d7

added support for extrema

20257d0

needed to modify other test for cargo test passing

e38c7e2

made cargo test happy

923d964

removed redundant code

b376f46

added description of lint

6136434

rustbot assigned Alexendoo Dec 11, 2023

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 11, 2023

intgr reviewed Dec 12, 2023

View reviewed changes

tests/ui/unnecessary_min.rs Outdated Show resolved Hide resolved

intgr reviewed Dec 12, 2023

View reviewed changes

tests/ui/unnecessary_min.rs Outdated Show resolved Hide resolved

FelixMaetzler and others added 3 commits December 13, 2023 15:55

remove useless comments

8d9d196

Co-authored-by: Marti Raudsepp <marti@juffo.org>

remove useless comments

072a077

Co-authored-by: Marti Raudsepp <marti@juffo.org>

modified the test files bc of last commit

7a32e98

Alexendoo reviewed Dec 13, 2023

View reviewed changes

FelixMaetzler added 2 commits December 15, 2023 13:04

got rid of get_both_as_expr

2d36617

used preexisting cmp method

d1a10bf

Merge branch 'master' into master

eabe0d5

rustbot added has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Dec 17, 2023

compiler-errors added 2 commits December 29, 2023 09:45

Appease the tools: clippy, rustdoc

768a615

Don't pass lint back out of lint decorator

dd39d48

Takashiidobe and others added 20 commits December 29, 2023 09:45

run cargo uibless

e7174b3

[question_mark]: also trigger on return statements

c5155b4

respect comments in question_mark

360bb44

Move uninhabited_references to nursery

c250f69

Remove blyxyas from users_on_vacation

d44f604

Do not consider async { (impl IntoFuture).await } as redundant

5dba66c

Added MSRV and more tests, improved wording

b23e4bc

formatting

21643a3

more tests

f208107

Update version attribute for 1.75 lints

ee59198

Changelog for Rust 1.75 🎄

08530ce

Fix typo in changelog for 1.75

cebb3e7

[doc_markdown]: Add "WebGL2", "WebGPU" to default doc_valid_idents

45bb4bd

new lint: eager_int_transmute

154a9ab

6459: Check for redundant matches! with Ready, Pending, V4, V6

69467a0

Bump nightly version -> 2023-12-28

7a8c109

Bump Clippy version -> 0.1.77

bf53b19

Remove mitigations for incorrect node args

b38f9cd

Merge branch 'master' into merge-conflicts

35ba1eb

Merge branch 'rust-lang:master' into merge-conflicts

c1b19e0

FelixMaetzler closed this Dec 30, 2023

FelixMaetzler deleted the merge-conflicts branch December 30, 2023 13:58

FelixMaetzler restored the merge-conflicts branch December 30, 2023 13:59

FelixMaetzler mentioned this pull request Dec 30, 2023

implemented unnecessary min #12061

Closed

		let cv = constant(cx, cx.typeck_results(), expr)?;

		match (ty.kind(), cv) {

Conversation

FelixMaetzler commented Dec 11, 2023

fixes #11924

Uh oh!

rustbot commented Dec 11, 2023

Uh oh!

FelixMaetzler commented Dec 11, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Alexendoo Dec 13, 2023

Choose a reason for hiding this comment

Uh oh!

FelixMaetzler Dec 14, 2023

Choose a reason for hiding this comment

Uh oh!

FelixMaetzler Dec 15, 2023

Choose a reason for hiding this comment

Uh oh!

bors commented Dec 16, 2023

Uh oh!

rustbot commented Dec 17, 2023

Uh oh!

FelixMaetzler commented Dec 17, 2023

Uh oh!

FelixMaetzler commented Dec 17, 2023

Uh oh!

bors commented Dec 26, 2023

Uh oh!

rustbot commented Dec 29, 2023

Uh oh!

rustbot commented Dec 29, 2023

Uh oh!

FelixMaetzler commented Dec 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cocodery commented Dec 30, 2023

Uh oh!

rustbot commented Dec 30, 2023

Uh oh!

FelixMaetzler commented Dec 30, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

FelixMaetzler commented Dec 29, 2023 •

edited

Loading