feat: add lint for ignored format precision on non-float types#16540
Open
nyurik wants to merge 1 commit intorust-lang:masterfrom
Open
feat: add lint for ignored format precision on non-float types#16540nyurik wants to merge 1 commit intorust-lang:masterfrom
nyurik wants to merge 1 commit intorust-lang:masterfrom
Conversation
Collaborator
|
r? @dswij rustbot has assigned @dswij. Use Why was this reviewer chosen?The reviewer was selected based on:
|
ada4a
approved these changes
Feb 18, 2026
This comment has been minimized.
This comment has been minimized.
77edce2 to
3929a88
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
Author
This comment has been minimized.
This comment has been minimized.
3929a88 to
c4c7ac8
Compare
This comment has been minimized.
This comment has been minimized.
c4c7ac8 to
2a01c10
Compare
This comment has been minimized.
This comment has been minimized.
2a01c10 to
cf2c1fd
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
cf2c1fd to
7cc6bed
Compare
This comment has been minimized.
This comment has been minimized.
7cc6bed to
913a981
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a new Clippy lint,
unused_format_precision, which warns when a precision specifier is used in formatting macros for types where it has no effect, such as integers, bool, char, and pointers. This helps catch misleading or potentially buggy formatting code.What it does
Detects use of format precision for standard non-float types where it has no effect
(integers, bool, char, pointers). Precision is meaningful for floats,
str(truncation), or user types.Why is this bad?
Specifying precision for these types is misleading and may indicate a bug. The value is ignored by the formatter.
Example
TODO
correctness- code that is outright wrong or uselesssuspicious- code that is most likely wrong or uselesscomplexity- code that does something simple but in a complex waychangelog: [
unused_format_precision]: new lint to catch ignored format precision on non-float types