Fixed build for latest rust master#2713
Merged
oli-obk merged 6 commits intorust-lang:masterfrom May 4, 2018
Merged
Conversation
Contributor
|
Retriggering travis |
Contributor
|
@alexreg: Looks like a few tests fail. |
Contributor
|
PR rust-lang/rust#49724 broke our range inclusive things. I'm fixing them atm |
Contributor
|
Clippy goes into an infinite loop on some input. I probably won't get to a machine where I can run gdb for the next few days :/ |
Contributor
Author
|
Tried to run the tests locally, but getting failures like this for clippy: |
Member
|
I don't see hangs on the Linux but inline and docs checks are messed up: Click me |
mati865
reviewed
May 4, 2018
Member
There was a problem hiding this comment.
Change == to !=.
With that change all tests passed on my Linux box.
Contributor
There was a problem hiding this comment.
Ah, superb. Let's see what travis says
Contributor
|
Whooo. Thanks everyone for the issue search and/or commits! I'll publish a new version later today |
Contributor
Author
|
Thanks for spotting that! Sorry about the sloppy edit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2708.