adding to restriction a lint that check for multiple inherent implementations#2816
Merged
oli-obk merged 3 commits intorust-lang:masterfrom May 31, 2018
mockersf:multiple-impl
Merged
adding to restriction a lint that check for multiple inherent implementations#2816oli-obk merged 3 commits intorust-lang:masterfrom mockersf:multiple-impl
oli-obk merged 3 commits intorust-lang:masterfrom
mockersf:multiple-impl
Conversation
oli-obk
reviewed
May 29, 2018
clippy_lints/src/inherent_impl.rs
Outdated
| /// ``` | ||
| declare_clippy_lint! { | ||
| pub MULTIPLE_INHERENT_IMPL, | ||
| pedantic, |
Contributor
There was a problem hiding this comment.
I'd rather have this in the restriction group. It's something that you don't generally want in my book, but can be very helpful for satisfying standards or company policy
Contributor
Author
|
oh well latest nightly is not happy with clippy 😢 |
Member
|
Nightly breakage is handled in #2817 |
Contributor
|
retriggering travis |
Member
|
@phansch It needs to be rebased on top of master branch to make Travis pass. |
Member
|
looks like you cherry picked the rustup? Please rebase over master instead 😄 |
Contributor
Author
|
my bad, my git-fu is not that good |
Contributor
Author
|
one of the integration build failed with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for #414
warn on each subsequent implementation of a
struct, with a note showing the first implementation