Merge new_without_default_derive into new_without_default#3558
Merge new_without_default_derive into new_without_default#3558bors merged 1 commit intorust-lang:masterfrom
Conversation
|
What is the correct way to remove lints like this? I figured it should have an associated |
|
ping from triage @russelltg. Could you address the review comment? The renaming function is already on master since #3554 |
|
☔ The latest upstream changes (presumably #3586) made this pull request unmergeable. Please resolve the merge conflicts. |
3963e3a to
cdd7f0d
Compare
|
The failures do not seem related to my changes, is there anything that I'm missing? |
|
Fixed in #3591 |
0e4d313 to
0a42dcb
Compare
|
☔ The latest upstream changes (presumably #3587) made this pull request unmergeable. Please resolve the merge conflicts. |
0afd9ef to
d127aed
Compare
|
So what's next? I don't think I can change the tags to be waiting on review |
|
It's done! We just need a ping sometimes 😉 @bors r+ Thanks! |
|
📌 Commit d127aed has been approved by |
Merge new_without_default_derive into new_without_default Closes #3525, deprecating new_without_default_derive and moving both lints into new_without_default.
|
☀️ Test successful - status-appveyor, status-travis |

Closes #3525, deprecating new_without_default_derive and moving both lints into new_without_default.