Place::Local(x) is now Place::Base(PlaceBase::Local(x))#3823
Merged
bors merged 1 commit intorust-lang:masterfrom Mar 1, 2019
Merged
Place::Local(x) is now Place::Base(PlaceBase::Local(x))#3823bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
Member
Author
|
@oli-obk this is mergeable now, just force pushed again because there was a conflict. |
Member
|
@spastorino it doesn't build: |
mati865
reviewed
Mar 1, 2019
clippy_lints/src/redundant_clone.rs
Outdated
| if let TerminatorKind::Call { func, args, destination, .. } = kind; | ||
| if args.len() == 1; | ||
| if let mir::Operand::Move(mir::Place::Local(local)) = &args[0]; | ||
| if let mir::Operand::Move(mir::Place::Base(PlaceBase(Local(local))) = &args[0]; |
Member
There was a problem hiding this comment.
Suggested change
| if let mir::Operand::Move(mir::Place::Base(PlaceBase(Local(local))) = &args[0]; | |
| if let mir::Operand::Move(mir::Place::Base(PlaceBase(Local(local)))) = &args[0]; |
It should fix the error.
Member
Author
There was a problem hiding this comment.
@mati865 doh but that's not the issue. PlaceBase::Local is the thing
Member
There was a problem hiding this comment.
I admit I haven't checked it deeply, thanks for the explanation.
Member
|
@bors r+ p=10 |
Contributor
|
📌 Commit 77a67c9 has been approved by |
bors
added a commit
that referenced
this pull request
Mar 1, 2019
Place::Local(x) is now Place::Base(PlaceBase::Local(x)) We need to merge this after the beta cut for this rust-lang/rust#58631 to work. /cc @oli-obk
Contributor
Contributor
|
☀️ Test successful - checks-travis, status-appveyor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to merge this after the beta cut for this rust-lang/rust#58631 to work.
/cc @oli-obk