Fix bug in implicit_hasher causing crashes#4268
Merged
Conversation
Skip linting if the type is from an external macro. Closes #4260.
flip1995
approved these changes
Jul 11, 2019
Member
|
Oh I forgot, that won't build until rust-lang/rust#62574 is merged. |
Member
|
@bors r+ |
Contributor
|
📌 Commit de77498 has been approved by |
Contributor
bors
added a commit
that referenced
this pull request
Jul 11, 2019
Fix bug in `implicit_hasher` causing crashes Skip linting if the type is from an external macro. Closes #4260. changelog: Fix bug in `implicit_hasher` causing crashes
Contributor
|
💔 Test failed - status-appveyor |
Member
|
Oh no. rustup-toolchain-install-master depends on serde too. So we have to wait on the next nightly to merge PRs again. |
flip1995
added
the
S-waiting-on-review
Member
|
@bors retry |
Contributor
bors
added a commit
that referenced
this pull request
Jul 12, 2019
Fix bug in `implicit_hasher` causing crashes Skip linting if the type is from an external macro. Closes #4260. changelog: Fix bug in `implicit_hasher` causing crashes
Contributor
|
💔 Test failed - status-appveyor |
flip1995
added a commit
to flip1995/rust-clippy
that referenced
this pull request
Jul 12, 2019
Fix bug in `implicit_hasher` causing crashes Skip linting if the type is from an external macro. Closes rust-lang#4260. changelog: Fix bug in `implicit_hasher` causing crashes
bors
added a commit
that referenced
this pull request
Jul 12, 2019
Fix bug in `implicit_hasher` causing crashes Skip linting if the type is from an external macro. Closes #4260. changelog: Fix bug in `implicit_hasher` causing crashes
Contributor
Contributor
|
💔 Test failed - checks-travis |
Member
|
@bors try the hyper ci failure that occurred earlier should be fixed now: hyperium/hyper#1863 |
Contributor
Contributor
|
💥 Test timed out |
Member
|
@bors r+ |
Contributor
|
💡 This pull request was already approved, no need to approve it again.
|
Contributor
|
📌 Commit de77498 has been approved by |
Contributor
bors
added a commit
that referenced
this pull request
Jul 13, 2019
Fix bug in `implicit_hasher` causing crashes Skip linting if the type is from an external macro. Closes #4260. changelog: Fix bug in `implicit_hasher` causing crashes
Contributor
|
☀️ Test successful - checks-travis, status-appveyor |
ghost
deleted the
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip linting if the type is from an external macro. Closes #4260.
changelog: Fix bug in
implicit_hashercausing crashes