Conversation
Member
|
Thanks! @bors r+ p=10 |
Contributor
|
📌 Commit 2c28225 has been approved by |
Contributor
bors
added a commit
that referenced
this pull request
Aug 28, 2019
Replace `Arg` with `Param` Fix build issue. Rustup to rust-lang/rust#63127 changelog: none
Contributor
|
☀️ Test successful - checks-travis, status-appveyor |
Member
Author
|
@flip1995 Could I submit a PR to rust-lang/rust to fix toolstate? |
Member
|
There is rust-lang/rust#63971 already |
Member
Author
|
@mati865 Oh, thanks! |
Member
|
Oh, I just did that. But yeah in the future you just can open a PR in rust-lang/rust to update Clippy. The TL;DR version on how to update a submodule in rustc: # Assuming you already cloned the rust repo and you're in the correct dir
$ git submodule update --remote src/tools/clippy
$ cargo update -p clippy
$ git add -u
$ git commit -m "Update Clippy"
$ ./x.py test -i --stage 1 src/tools/clippy # This is optional and should succeed anyway
# Open a PR in rust-lang/rust |
Contributor
|
Might be nice to add that script to our repo; I have my own version and I assume @matthiaskrgr also has some sort of script 😅 |
bors
added a commit
that referenced
this pull request
Aug 28, 2019
Add note to fix toolstate The idea from #4462 (comment) It's nice that we have the documentation to guide fix toolstate. changelog: none
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Aug 29, 2019
Update Clippy cc rust-lang/rust-clippy#4462 r? @oli-obk @Manishearth
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix build issue.
Rustup to rust-lang/rust#63127
changelog: none