Changes cast-lossless to a pedantic lint#4539
Merged
bors merged 1 commit intorust-lang:masterfrom Sep 19, 2019
jolson88:cast-lossless-pedantic
Merged
Changes cast-lossless to a pedantic lint#4539bors merged 1 commit intorust-lang:masterfrom jolson88:cast-lossless-pedantic
bors merged 1 commit intorust-lang:masterfrom
jolson88:cast-lossless-pedantic
Conversation
|
You need to update the category where the lint is declared using the |
flip1995
added
the
S-waiting-on-author
Contributor
Author
|
Great! Thanks Mike. I'll do that this evening and get the PR updated :). |
Contributor
Author
|
Updated and corrected tests. I think (?) that the build failures are from the needed change to the clippy-driver: rust-lang/rust#64440 |
Contributor
|
going to retrigger the PR build |
Contributor
Author
|
Here's the PR and change that caused the new build failures: https://github.com/rust-lang/rust/pull/60584/files#diff-707a0eda6b2f1a0537abc3d23133748cL1151. I will get a new PR opened soon to fix that issue. |
Contributor
Author
|
PR opened for the breaking change: #4545. |
Member
|
@bors r+ rollup |
Contributor
|
📌 Commit 6f1f413 has been approved by |
flip1995
added a commit
to flip1995/rust-clippy
that referenced
this pull request
Sep 19, 2019
…lip1995 Changes cast-lossless to a pedantic lint As discussed in rust-lang#4528, this moves the cast-lossless lint from `all` to `pedantic`. I couldn't tell from description alone if it should also be removed from the complexity category, so I left it as part of complexity for now. I didn't see any impact to the tests from this change, but I could be wrong (as this is my first PR). fixes rust-lang#4528 changelog: Moves cast-lossless from default to checking only as a `pedantic` lint.
flip1995
added a commit
to flip1995/rust-clippy
that referenced
this pull request
Sep 19, 2019
…lip1995 Changes cast-lossless to a pedantic lint As discussed in rust-lang#4528, this moves the cast-lossless lint from `all` to `pedantic`. I couldn't tell from description alone if it should also be removed from the complexity category, so I left it as part of complexity for now. I didn't see any impact to the tests from this change, but I could be wrong (as this is my first PR). fixes rust-lang#4528 changelog: Moves cast-lossless from default to checking only as a `pedantic` lint.
bors
added a commit
that referenced
this pull request
Sep 19, 2019
Rollup of 4 pull requests Successful merges: - #4511 (New lint: mem_replace_with_uninit) - #4535 (New lint: Require `# Safety` section in pub unsafe fn docs) - #4539 (Changes cast-lossless to a pedantic lint) - #4544 (#4542 remove machine applicable suggestion) Failed merges: r? @ghost changelog: none
Contributor
bors
added a commit
that referenced
this pull request
Sep 19, 2019
Changes cast-lossless to a pedantic lint As discussed in #4528, this moves the cast-lossless lint from `all` to `pedantic`. I couldn't tell from description alone if it should also be removed from the complexity category, so I left it as part of complexity for now. I didn't see any impact to the tests from this change, but I could be wrong (as this is my first PR). fixes #4528 changelog: Moves cast-lossless from default to checking only as a `pedantic` lint.
Contributor
|
☀️ Test successful - checks-travis, status-appveyor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #4528, this moves the cast-lossless lint from
alltopedantic.I couldn't tell from description alone if it should also be removed from the complexity category, so I left it as part of complexity for now. I didn't see any impact to the tests from this change, but I could be wrong (as this is my first PR).
fixes #4528
changelog: Moves cast-lossless from default to checking only as a
pedanticlint.