Fix rustc breaking change: convert to Place's new boxed slice projection#4540
Merged
bors merged 1 commit intorust-lang:masterfrom Sep 14, 2019
jolson88:fix-place-projection
Merged
Fix rustc breaking change: convert to Place's new boxed slice projection#4540bors merged 1 commit intorust-lang:masterfrom jolson88:fix-place-projection
bors merged 1 commit intorust-lang:masterfrom
jolson88:fix-place-projection
Conversation
Fixes breaking change from rust-lang PR rust-lang/rust#63420
jolson88
changed the title
spastorino
approved these changes
Sep 14, 2019
Member
|
Made some comments but I was confused, this looks perfect and changes doesn't change semantics. Good to merge. |
Contributor
|
I can't claim any knowledge either here, but given @spastorino's approval and that there's no visible regressions I'm gonna @bors r+ Thanks! |
Contributor
|
📌 Commit 80822b4 has been approved by |
Contributor
bors
added a commit
that referenced
this pull request
Sep 14, 2019
Fix rustc breaking change: convert to Place's new boxed slice projection Addressed breaking changes from rust-lang PR rust-lang/rust#63420 I'm not entirely sure the semantics are preserved as I don't have much knowledge about MIR yet. So this code was largely reverse-engineered from the PR above. I wouldn't be surprised if I did something wrong :). I followed the instructions to pull latest rustc from master and verified the build break I was seeing in my PR for cast-lossless in Travis CI. With these changes, it compiles again and all tests pass. Fixes rust-lang/rust#64440 changelog: none
llogiq
reviewed
Sep 14, 2019
| if let PlaceBase::Local(local) = place_base { | ||
| while let Some(box Projection { base, elem }) = projection { | ||
| while let [base @ .., elem] = projection { | ||
| projection = base; |
Contributor
|
☀️ Test successful - checks-travis, status-appveyor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressed breaking changes from rust-lang PR rust-lang/rust#63420
I'm not entirely sure the semantics are preserved as I don't have much knowledge about MIR yet. So this code was largely reverse-engineered from the PR above. I wouldn't be surprised if I did something wrong :).
I followed the instructions to pull latest rustc from master and verified the build break I was seeing in my PR for cast-lossless in Travis CI. With these changes, it compiles again and all tests pass.
Fixes rust-lang/rust#64440
changelog: none