generate stderr file on 32bit pointer system

[tesuji]

changelog: none

[phansch]

@bors r+

[bors]

📌 Commit 1f96524 has been approved by phansch

[bors]

⌛ Testing commit 1f96524 with merge ebcf8b2...

[flip1995]

@bors r-

(I think the PR author can r- bors. At least you can do this in rust-lang/rust)

[tesuji]

It is unfortunate that I couldn't build for i686 target directly on x86-64 system.
I kept getting error missing crate rustc.

[flip1995]

It seems to work though. We don't test this in travis anyway, since travis also runs on 64bit. I think this is more an alibi test 😄

[tesuji]

The problem is that we couldn't cross-build tools: See rust-lang/rust#62558 for details.

[mati865]

It will fail if somebody tries to run it on 64bit system other than x86_64, like Aarch64.
In that case lesser evil would be to run this test only on x86.

I think you should be able to install i686 host toolchain on x86_64 system and use it to build Clippy "natively".

[tesuji]

Thanks. I will try to add build job for i688 target later.

[tesuji]

So I got the following errors on my x86_64 linux system:

% cargo check --all-targets --workspace --target i686-unknown-linux-gnu                    
   Compiling cargo_metadata v0.8.2
    Checking clippy_lints v0.0.212 (/home/lzutao/fork/rust/clippy/clippy_lints)
    Checking compiletest_rs v0.3.25
error[E0463]: can't find crate for `rustc_macros` which `rustc` depends on
  --> /home/lzutao/.cargo/registry/src/github.com-1ecc6299db9ec823/compiletest_rs-0.3.25/src/lib.rs:19:1
   |
19 | extern crate rustc;
   | ^^^^^^^^^^^^^^^^^^^ can't find crate

error: aborting due to previous error

For more information about this error, try `rustc --explain E0463`.

[mati865]

@lzutao you cannot cross compile it because of Rust bug.
You need i686 host toolchain.

[tesuji]

I see it now. Thanks @mati865 . This now just needs a rustup.

[tesuji]

Error reading rustc version. What am I doing wrong?
https://travis-ci.com/rust-lang/rust-clippy/jobs/248209462#L174

[mati865]

It has something to do either with Ubuntu or Travis.
On my x86_64 Arch Linux:

$ rustc +nightly-2019-10-20-i686-unknown-linux-gnu -vV                                                                                                                                  
rustc 1.40.0-nightly (c23a7aa77 2019-10-19)
binary: rustc
commit-hash: c23a7aa778b0dfeffbf83b099bdf971242c1e1ac
commit-date: 2019-10-19
host: i686-unknown-linux-gnu
release: 1.40.0-nightly
LLVM version: 9.0

[tesuji]

I don't want to deal with this further.
Let's block this PR on #4714 .

[bors]

☔ The latest upstream changes (presumably #4856) made this pull request unmergeable. Please resolve the merge conflicts.

[tesuji]

The build is green: https://travis-ci.com/rust-lang/rust-clippy/jobs/261809318

[flip1995]

Thanks!

@bors r+

[bors]

📌 Commit 7156aa7 has been approved by flip1995

[bors]

⌛ Testing commit 7156aa7 with merge 45196ce...

[bors]

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing 45196ce to master...