Remove extern crate clippy_lints from tests#4784
Merged
bors merged 2 commits intorust-lang:masterfrom Nov 7, 2019
Merged
Conversation
Member
|
Looks like some tests are still failing..? (or broke again in the meantime) |
Contributor
|
This shouldn't be necessary, see rust-lang/rust#66158 (comment) |
flip1995
reviewed
Nov 7, 2019
| #[macro_use] | ||
| extern crate clippy_lints; | ||
|
|
||
| declare_clippy_lint! { |
Member
There was a problem hiding this comment.
Instead of removing this test, we can change this to the declare_lint macro from rustc. The intend of this test would persist.
Manishearth
force-pushed
the
remove-extern
branch
from
7452283 to
4721f44
Compare
Member
Author
Contributor
|
📌 Commit 4721f44 has been approved by |
Contributor
bors
added a commit
that referenced
this pull request
Nov 7, 2019
Remove `extern crate clippy_lints` from tests This causes rustc's build system to fail because it still tries to load the crate as a plugin: rust-lang/rust#66158 (comment) . I'm not sure _why_ this happens, but for a short term fix we should remove these. In one case it was just a convenient crate to use so i picked a different test. In another it was load-bearing, I had to delete the test. Idk if there's a better way around this. changelog: none
Contributor
|
☀️ Test successful - checks-travis, status-appveyor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This causes rustc's build system to fail because it still tries to load the crate as a plugin: rust-lang/rust#66158 (comment) . I'm not sure why this happens, but for a short term fix we should remove these.
In one case it was just a convenient crate to use so i picked a different test. In another it was load-bearing, I had to delete the test. Idk if there's a better way around this.
changelog: none