Issue/4623#4806
Merged
bors merged 2 commits intorust-lang:masterfrom Nov 23, 2019
FlorianRohm:issue/4623
Merged
Conversation
flip1995
requested changes
Nov 12, 2019
Member
flip1995
left a comment
flip1995
left a comment
There was a problem hiding this comment.
Thanks for the contribution and welcome to Clippy!
Great job for your first contribution to the rust ecosystem! (Keep contributing 😉)
Most of my review comments are just NITs.
flip1995
added
the
S-waiting-on-author
FlorianRohm
commented
Nov 12, 2019
flip1995
reviewed
Nov 13, 2019
flip1995
approved these changes
Nov 15, 2019
Member
|
Thanks! Please squash some commits and this can get merged. |
Author
|
done 👍 |
flip1995
approved these changes
Nov 18, 2019
Member
flip1995
left a comment
flip1995
left a comment
There was a problem hiding this comment.
Thanks! I'm currently working on a rustup. After that, we can merge this.
Author
|
mh, I would need someone with write Access to merge this pr. |
Member
|
Yeah, I will, once #4825 is merged :) |
Member
|
@bors r+ rollup |
Contributor
|
📌 Commit 73806b7 has been approved by |
Member
|
@bors rollup- |
bors
added a commit
that referenced
this pull request
Nov 23, 2019
Issue/4623 Greetings. This PR is intended to close #4623 Feedback very welcome, as this is out first contribution to the rust ecosystem :) --- - [x] Followed [lint naming conventions][lint_naming] - allow tabs_in_doc_comments reads well - [x] Added passing UI tests (including committed `.stderr` file) - [x] `cargo test` passes locally - [x] Executed `./util/dev update_lints` - [x] Added lint documentation - [x] Run `./util/dev fmt` --- changelog: added lint "tabs_in_doc_comments"
Contributor
Member
|
@bors retry queu prio |
bors
added a commit
that referenced
this pull request
Nov 23, 2019
Rollup of 4 Pull requests with new lints Rollup of pull requests - #4816 (New lint: zst_offset) - #4814 (New lint: Implement ifs_same_cond_fn) - #4807 (Add `large_stack_arrays` lint) - #4806 (Issue/4623) changelog: add [`zst_offset`] lint changelog: New lint: [`ifs_same_cond_fn`] cahngelog: Add new lint [large_stack_arrays] changelog: added lint [`tabs_in_doc_comments`]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greetings.
This PR is intended to close #4623
Feedback very welcome, as this is out first contribution to the rust ecosystem :)
.stderrfile)cargo testpasses locally./util/dev update_lints./util/dev fmtchangelog: added lint "tabs_in_doc_comments"