Temporarily downgrade match_wildcard_for_single_variants to nursery#6985
Closed
dtolnay wants to merge 1 commit intorust-lang:masterfrom
Closed
Temporarily downgrade match_wildcard_for_single_variants to nursery#6985dtolnay wants to merge 1 commit intorust-lang:masterfrom
dtolnay wants to merge 1 commit intorust-lang:masterfrom
Conversation
|
r? @giraffate (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Contributor
|
Thanks! The false positive may be fixed by #6988. |
Contributor
Contributor
|
☔ The latest upstream changes (presumably #6931) made this pull request unmergeable. Please resolve the merge conflicts. |
dtolnay
commented
Apr 9, 2021
Member
Author
dtolnay
left a comment
dtolnay
left a comment
There was a problem hiding this comment.
Confirmed fixed in nightly-2021-04-09, so this is no longer needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The false positive in #6984 (which started appearing in the most recent nightly) makes this lint actively damaging for enums such as https://github.com/dtolnay/syn/blob/17332d952a3bc58e95692f313d595bd019f31d39/src/expr.rs#L227-L251, so I believe it is worth turning off for now until fixed, even for people who lint their code with
warn(clippy::pedantic).changelog: Bump match_wildcard_for_single_variants lint from pedantic to nursery