Allow giving reasons for disallowed_methods#7621
Allow giving reasons for disallowed_methods#7621bors merged 1 commit intorust-lang:masterfrom azdavis:master
disallowed_methods#7621Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @camsteffen (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
azdavis
changed the title
disallowed_methods]disallowed_methods
|
☔ The latest upstream changes (presumably #7604) made this pull request unmergeable. Please resolve the merge conflicts. |
|
rebased and force-pushed to address feedback |
camsteffen
left a comment
camsteffen
left a comment
There was a problem hiding this comment.
This is nice! Just a few nits.
tests/ui-toml/toml_disallowed_method/conf_disallowed_method.stderr
Outdated
Show resolved
Hide resolved
camsteffen
left a comment
camsteffen
left a comment
There was a problem hiding this comment.
Looks good! Please squash commits.
|
ok, rebased and squashed into 1 commit |
|
Thanks and nice first contribution! @bors r+ |
|
📌 Commit 293db0d has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
5 participants
Fixes #7609.
This permits writing the config for
disallowed-methodsas either a list of strings (like before) or a list of tables, where each table gives the path to the disallowed method and an optional reason for why the method is disallowed.changelog: Allow giving reasons for [
disallowed_methods]