Move if_then_panic to pedantic and rename to manual_assert#7810
Merged
bors merged 2 commits intorust-lang:masterfrom Oct 28, 2021
Merged
Move if_then_panic to pedantic and rename to manual_assert#7810bors merged 2 commits intorust-lang:masterfrom
bors merged 2 commits intorust-lang:masterfrom
Conversation
|
r? @flip1995 (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Contributor
Author
|
Perhaps I should rename to |
camsteffen
force-pushed
the
if-then-panic-pedantic
branch
from
461da36 to
582bf9a
Compare
camsteffen
changed the title
Contributor
|
☔ The latest upstream changes (presumably #7743) made this pull request unmergeable. Please resolve the merge conflicts. |
Merged
flip1995
approved these changes
Oct 28, 2021
Member
flip1995
left a comment
flip1995
left a comment
There was a problem hiding this comment.
Whoops, I should have reviewed this earlier...
r=me after rebase
We can still backport this to beta.
camsteffen
force-pushed
the
if-then-panic-pedantic
branch
from
582bf9a to
4d4ab83
Compare
camsteffen
force-pushed
the
if-then-panic-pedantic
branch
from
4d4ab83 to
022146d
Compare
Contributor
Author
|
I changed the lint name references in the changelog @bors r=flip1995 |
Contributor
|
📌 Commit 022146d has been approved by |
Contributor
Contributor
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
This was referenced Oct 28, 2021
flip1995
pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
Nov 3, 2021
…lip1995 Move if_then_panic to pedantic and rename to manual_assert
bors
added a commit
that referenced
this pull request
Nov 3, 2021
[beta] Backport: Move if_then_panic to pedantic and rename to manual_assert Backport of #7810 cc `@camsteffen` r? `@ghost` changelog: none (same release)
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 19, 2021
…lacrum [beta] Backport Clippy lint renaming / regrouping This backports PR rust-lang/rust-clippy#7810 to beta, where a lint added in the 1.57 (current beta) release cycle was renamed shortly after the beta cutoff. We want to backport this, so we don't have unnecessary `lint_store.registered_renamed` calls in the Clippy codebase forever. (The formatting changes were necessary to pass this backport in the Clippy CI, removing it in a subtree sync would be a bit painful...) cc `@camsteffen`
bors bot
referenced
this pull request
in godot-rust/gdnative
Nov 27, 2021
822: Fix/suppress clippy lints on nightly r=Bromeon a=chitoyuu - Modified `LocalCell<T>` so the destructor is not called on a different thread. Allowed `clippy::non_send_fields_in_send_ty` otherwise. - Removed mentions of `if_then_panic` which is no longer a thing (`https://github.com/rust-lang/rust-clippy/pull/7810`). - A few other minor fixes. Co-authored-by: Chitose Yuuzaki <chitoyuu@potatoes.gay>
GuilhermeOrceziae
referenced
this pull request
in GuilhermeOrceziae/godot-rust
Feb 9, 2023
822: Fix/suppress clippy lints on nightly r=Bromeon a=chitoyuu - Modified `LocalCell<T>` so the destructor is not called on a different thread. Allowed `clippy::non_send_fields_in_send_ty` otherwise. - Removed mentions of `if_then_panic` which is no longer a thing (`https://github.com/rust-lang/rust-clippy/pull/7810`). - A few other minor fixes. Co-authored-by: Chitose Yuuzaki <chitoyuu@potatoes.gay>
hesuteia
referenced
this pull request
in hesuteia/godot-rust
Feb 11, 2023
822: Fix/suppress clippy lints on nightly r=Bromeon a=chitoyuu - Modified `LocalCell<T>` so the destructor is not called on a different thread. Allowed `clippy::non_send_fields_in_send_ty` otherwise. - Removed mentions of `if_then_panic` which is no longer a thing (`https://github.com/rust-lang/rust-clippy/pull/7810`). - A few other minor fixes. Co-authored-by: Chitose Yuuzaki <chitoyuu@potatoes.gay>
ecobiubiu
referenced
this pull request
in ecobiubiu/open-rust
Mar 30, 2023
822: Fix/suppress clippy lints on nightly r=Bromeon a=chitoyuu - Modified `LocalCell<T>` so the destructor is not called on a different thread. Allowed `clippy::non_send_fields_in_send_ty` otherwise. - Removed mentions of `if_then_panic` which is no longer a thing (`https://github.com/rust-lang/rust-clippy/pull/7810`). - A few other minor fixes. Co-authored-by: Chitose Yuuzaki <chitoyuu@potatoes.gay>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7718
changelog: none (lint added since last release)