Fix SAFETY comment tag casing in undocumented_unsafe_blocks#8138
Conversation
|
r? @giraffate (rust-highfive has picked a reviewer for you, use r? to override) |
|
I like standardizing the capitalization. 👍 You might also want to take a look at the |
|
@xFrednet I think in that case |
|
@bors r+ Thanks! |
|
📌 Commit eba4413 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
This changes the lint introduced in #7748 to suggest adding a
SAFETYcomment instead of aSafetycomment.Searching for
// Safety:in rust-lang/rust yields 67 results while// SAFETY:yields 1072.I think it's safe to say that this comment tag is written in upper case, just like
TODO,FIXMEand so on are. As such I would expect this lint to follow the official convention as well.Note that I intentionally introduced some casing diversity in
tests/ui/undocumented_unsafe_blocks.rsto test more cases than justSafety:.changelog: Capitalize
SAFETYcomment in [undocumented_unsafe_blocks]