Format if_chain invocations in clippy_utils#8370
Merged
bors merged 1 commit intorust-lang:masterfrom Feb 1, 2022
Merged
Conversation
|
r? @flip1995 (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Member
|
Thanks! This is an improvement of the formatting. Probably not necessary soon, once we switch to let_chains, but until we can make the move, I'm happy to merge this. @bors r+ |
Contributor
|
📌 Commit e7922f7 has been approved by |
bors
added a commit
that referenced
this pull request
Feb 1, 2022
Format `if_chain` invocations in clippy_utils Not realizing it was [already obsolete](#8360), I built a [tool to format inside `if_chain` invocations](https://crates.io/crates/rustfmt_if_chain). This PR applies the tool to clippy_utils. (If you apply it to clippy_lints, the changes are extensive.) Anyway, I'm making it known here in case anyone wants to use it while `if-let` chain support is developed for `rustfmt`. (There could be a few Clippy PRs between now and then, and IMHO, the code looks better with the `if_chain` invocations formatted.) Cheers.
Contributor
Contributor
|
💔 Test failed - checks-action_test |
Contributor
|
The changelog entry was missing. I added @bors retry |
Contributor
Contributor
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not realizing it was already obsolete, I built a tool to format inside
if_chaininvocations.This PR applies the tool to clippy_utils. (If you apply it to clippy_lints, the changes are extensive.)
Anyway, I'm making it known here in case anyone wants to use it while
if-letchain support is developed forrustfmt. (There could be a few Clippy PRs between now and then, and IMHO, the code looks better with theif_chaininvocations formatted.)Cheers.
changelog: none