Fixes #9677 - Lint against mod lib;

[st3fan]

Warning: Noob in action. This is my first attempt to work on #9677 - work in progress. There is a lot to fix and clean up here.

--

Thank you for making Clippy better!

We're collecting our changelog from pull request descriptions.
If your PR only includes internal changes, you can just write
changelog: none. Otherwise, please write a short comment
explaining your change.

It's also helpful for us that the lint name is put within backticks (` `),
and then encapsulated by square brackets ([]), for example:

changelog: [`lint_name`]: your change

If your PR fixes an issue, you can add fixes #issue_number into this
PR description. This way the issue will be automatically closed when
your PR is merged.

If you added a new lint, here's a checklist for things that will be
checked during review or continuous integration.

• Followed lint naming conventions
• Added passing UI tests (including committed .stderr file)
• cargo test passes locally
• Executed cargo dev update_lints
• Added lint documentation
• Run cargo dev fmt

Note that you can skip the above if you are just opening a WIP PR in
order to get feedback.

Delete this line and everything above before opening your PR.

---

Please write a short comment explaining your change (or "none" for internal only changes)

changelog:

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @llogiq (or someone else) soon.

Please see the contribution instructions for more information.

[kraktus]

Hey, thanks for working on this! I know this PR isn’t ready for review, just wanted to say we’re trying to make all new lints to use ‘LateLintPass’, cheers! Feel free to share any of your issues

[st3fan]

Thanks @kraktus I've updated the code to implement LateLintPass instead. Am I going in the right direction here?

[kraktus]

It does! Looks like your lint is not registered yet, using cargo new_lint (don’t remember the exact name of the subcommand, find it with cargo —help while in clippy repo, will create the skeleton of the lint for you

[llogiq]

Actually cargo dev update_lint should suffice in the current situation. The lint exists, but it isn't yet registered.

[llogiq]

I think a mod lib { } should suffice here, which obviates the need for a secondary file.

[bors]

☔ The latest upstream changes (presumably #9506) made this pull request unmergeable. Please resolve the merge conflicts.

[llogiq]

Ping! Do you still plan working on this? I think with a rebase and running cargo dev update_lints this might mostly be mergeworthy.

@rustbot author

[Alexendoo]

cross-posting #9677 (comment)