Improved existing setup for zizmorchecks#1062
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) some time within the next two weeks. Why was this reviewer chosen?The reviewer was selected based on:
|
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
| inputs: .github/workflows | ||
| persona: pedantic | ||
| min-severity: low |
There was a problem hiding this comment.
If I got this input correctly, it acts like a filter for findings. Most likely we don't want to have any filters
| run: zizmor --persona pedantic --min-severity low .github/workflows | ||
| - name: Run zizmor | ||
| uses: zizmorcore/zizmor-action@5f14fd08f7cf1cb1609c1e344975f152c7ee938d # v0.5.6 | ||
| with: |
There was a problem hiding this comment.
We should also opt-out from Github Advance Security, since we want to fail the CI in case there are any zizmor findings, at least for now
| - name: Run zizmor | ||
| uses: zizmorcore/zizmor-action@5f14fd08f7cf1cb1609c1e344975f152c7ee938d # v0.5.6 | ||
| with: | ||
| inputs: .github/workflows |
There was a problem hiding this comment.
Since the default path for inputs collection is ., we can remove this one
I kept the audit behavior the same as #1037 still
pedanticpersona, stillmin-severity: low, still pointed at.github/workflows. The main differenceis that the install step is gone and the action now uploads its findings as
SARIF, so they show up in the Security tab instead of only in the workflow logs.
For that SARIF upload to work the job needs
security-events: write,contents: read, andactions: read, so I added those at the job leveland tightened the workflow-level permissions to
{}while I was there.The action is pinned by commit SHA (
v0.5.6) to keep zizmor's ownunpinned-usesrule happy, same convention as #1037.Closes #1061.