This repository was archived by the owner on Aug 25, 2025. It is now read-only.
template: Update tr(1) usage for Solaris compat#124
Open
inferiorhumanorgans wants to merge 1 commit intorust-lang:masterfrom
Open
template: Update tr(1) usage for Solaris compat#124inferiorhumanorgans wants to merge 1 commit intorust-lang:masterfrom
inferiorhumanorgans wants to merge 1 commit intorust-lang:masterfrom
Conversation
Seems like wrapping the character range with square brackets is safe for both BSD and GNU tr. Without the brackets Solaris' tr(1) chokes and treats - as a literal and not a range despite the man page suggesting otherwise. On Solaris: $ echo 'foobar-1' | /usr/bin/tr 'a-z-' 'A-Z_' foobAr_1 $ echo 'foobar-1' | /usr/bin/tr '[a-z]-' '[A-Z]_' FOOBAR_1 On macOS 10.14: $ echo 'foobar-1' | /usr/bin/tr '[a-z]-' '[A-Z]_' FOOBAR_1 $ echo 'foobar-1' | /usr/bin/tr '[a-z]-' '[A-Z]_' FOOBAR_1 $ gtr --version tr (GNU coreutils) 9.3 Copyright (C) 2023 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later <https://gnu.org/licenses/gpl.html>. This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Written by Jim Meyering. $ echo 'foobar-1' | /opt/local/bin/gtr '[a-z]-' '[A-Z]_' FOOBAR_1 $ echo 'foobar-1' | /opt/local/bin/gtr '[a-z]-' '[A-Z]_' FOOBAR_1
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon. |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems like wrapping the character range with square brackets is safe for both BSD and GNU
tr(1). Without the brackets Solaris'tr(1)chokes and treats-as a literal and not a range despite the man page suggesting otherwise. The SUSv2 (/usr/xpg4/bin/tr) and SUSv3 (/usr/xpg6/bin/tr) versions likewise don't function as intended without the brackets.With these changes in place the installer works on Solaris 11.4.
On Solaris:
On macOS 10.14: