visit enum init when the enum variable doesn't have any parameters by lyming2007 · Pull Request #102984 · rust-lang/rust

lyming2007 · 2022-10-12T20:34:22Z

this will fix #101208

rust-highfive · 2022-10-12T20:34:25Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nagisa (or someone else) soon.

Please see the contribution instructions for more information.

compiler-errors · 2022-10-13T18:03:39Z

Is this a duplicate of #102062? Which one of these is the preferred fix?

compiler-errors · 2022-10-13T18:05:00Z

As I noted on #102062, I feel like this logic overlaps very heavily with FnCtxt::suggest_fn_call -- is it possible to use that instead?

lyming2007 · 2022-10-13T18:18:11Z

As I noted on #102062, I feel like this logic overlaps very heavily with FnCtxt::suggest_fn_call -- is it possible to use that instead?

There is no respond for #102062 since a long time ago.
And I found we don't need to modify the file compiler/rustc_span/src/span_encoding.rs which caused the conflict.
So this one(#102984) is actually a more less expensive fix.
That's why I've created a new one.

compiler-errors · 2022-10-13T18:25:04Z

@lyming2007 in the future, you can just update the older PR with a new approach. If it has been a long time since it was reviewed, then please ping the reviewer.

I will close the older one since they achieve the same purpose.

lyming2007 · 2022-10-13T18:29:28Z

@lyming2007 in the future, you can just update the older PR with a new approach. If it has been a long time since it was reviewed, then please ping the reviewer.

I will close the older one since they achieve the same purpose.

Thank you for the suggestion. I will do that in the future

nagisa · 2022-10-18T11:49:19Z

r? @compiler-errors

bors · 2022-10-21T13:25:51Z

☔ The latest upstream changes (presumably #103310) made this pull request unmergeable. Please resolve the merge conflicts.

Co-authored-by: Ralf Jung <post@ralfj.de>

Rough timeline: * The longer `.content .item-info` selector originated in 110e727. No reason seems to be given in the PR why it needed the `.content` part, but it was probably added because of <https://github.com/rust-lang/rust/blob/110e7270ab7b0700ce714b8b1c7e509195dea2c4/src/librustdoc/html/static/rustdoc.css#L476-L478>. That selector with the margin-bottom was removed when CSS containment was added in 8846c08. * `.stability` was renamed `.item-info` in caf6c57. * The selector without the `.content` was added in d48a39a.

…errors This way we comply with the Coherence rule given that IntoDiagnostic trait is defined in rustc_errors, and almost all other crates depend on it.

This rule originated as a `font-size: 16px`, when body had `font-size: 13px` set in 4fd061c. It remained even when body's font size was bumped up to 16px, 4d5f4ff, making the rule a no-op, and was carried forward when it was converted to 1rem in cc18120.

…s input vs output

…tions

io_safety was stabilized in Rust 1.63, so mark the io_safety exports in `std::os::wasi::io` as stable. Fixes rust-lang#103306.

…rait

This commit changes things so that the search bar is exactly centered between the top of the page and the top of the source code content area.

rustbot · 2022-10-21T21:15:17Z

A change occurred in the Ayu theme.

cc @Cldfire

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

Some changes occurred in need_type_info.rs

cc @lcnr

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

Some changes occurred in src/tools/cargo

cc @ehuss

This PR changes MIR

cc @oli-obk, @RalfJung, @JakobDegen, @davidtwco, @celinval, @vakaras

rustc_errors::translation was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki

The Miri subtree was changed

cc @rust-lang/miri

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

rustc_macros::diagnostics was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki

Some changes occurred in HTML/CSS themes.

cc @GuillaumeGomez

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @Folyd, @jsha

Some changes occurred in src/librustdoc/clean/types.rs

cc @camelid

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo

Some changes occurred in const_evaluatable.rs

cc @lcnr

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

compiler-errors · 2022-10-21T21:18:38Z

@lyming2007 you did the rebase incorrectly. I think you need to do:

git pull --rebase $ORIGIN master

where $ORIGIN is whatever git remote that is set up to track rust-lang/rust.

lyming2007 · 2022-10-21T21:35:17Z

@lyming2007 you did the rebase incorrectly. I think you need to do:
git pull --rebase $ORIGIN master
where $ORIGIN is whatever git remote that is set up to track rust-lang/rust.
When I tried to merge the code, it keeps asking me to fix the conflict of Cargo.lock which I nerve touched before.
Seems it's much easier to create a new PR than doing the merge.
Can I create a new one and abandon the current one?
I will do as you suggested later

lyming2007 · 2022-10-21T21:37:46Z

this PR was broken by me obviously

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Oct 12, 2022

rust-highfive assigned nagisa Oct 12, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 12, 2022

This comment has been minimized.

Sign in to view

lyming2007 force-pushed the issue-101208-fix branch 2 times, most recently from 3dd7ff2 to b31086a Compare October 12, 2022 22:28

rust-highfive assigned compiler-errors and unassigned nagisa Oct 18, 2022

Noratrieb and others added 14 commits October 21, 2022 14:05

Use tidy-alphabetical in the compiler

35a04bd

Error if tidy-alphabetical-end was not found

a7ccf16

Show command line arguments

ba9d27a

Apply suggestions from code review

7799078

Co-authored-by: Ralf Jung <post@ralfj.de>

link lint function with decorate function param to struct_lint_level

8914cf0

add test for issue 102964

8722e9f

Set opt-level = 1 on dev profile

2590baf

Avoid format! in favor of to_string

8ba47d9

Add broken test for AFIT with RPITIT

2a835c2

fix small word dupe typos

51ad577

Cast runnableEnv items to string

1af8fea

ADD - IntoDiagnostic conformance for TargetDataLayoutErrors in rustc_…

f6d6929

…errors This way we comply with the Coherence rule given that IntoDiagnostic trait is defined in rustc_errors, and almost all other crates depend on it.

UPDATE - Move IntoDiagnosticArg implementations to diagnostic_impls file

ed363be

spastorino and others added 25 commits October 21, 2022 14:14

Extract orig_opt_local_def_id as a function

74c6eb8

Do anonymous lifetimes remapping correctly for nested rpits

aef75d1

Remove extra spaces

be7e80b

Erase regions before checking for default in uninitialized binding error

c68e9f2

Adjusting test to needs-unwind, with linking issue

21b2597

Fixed docs typo in library/std/src/time.rs

74ee999

check if impl_self is Some

87edf20

Adjust transmute{,_copy} to be clearer about which of T and U i…

d55df4f

…s input vs output

Implement assertions and fixes to not emit empty spans without sugges…

687db5a

…tions

+/- shortcut now only expand/collapse, not both

731f805

Add GUI tests for collapse/expand actions

24d41d2

fix typo

00fd02c

Mark std::os::wasi::io::AsFd etc. as stable.

51df6cc

io_safety was stabilized in Rust 1.63, so mark the io_safety exports in `std::os::wasi::io` as stable. Fixes rust-lang#103306.

rustc_hir_typeck: move whole files

f90a574

rustc_hir_typeck: fix paths and partially mv files

521ee23

rustc_hir_typeck: fix clippy

299f7d7

add increased recursion limit

904437c

no test in testsuite label

e84fba4

interpret: remove an incorrect assertion

b216d30

Elaborate supertrait bounds when triggering unused_must_use on impl T…

1213363

…rait

Improve "~const is not allowed here" message

9dee8d9

rustdoc: improve appearance of source page navigation bar

9cf2ada

This commit changes things so that the search bar is exactly centered between the top of the page and the top of the source code content area.

Make the whole std::os::wasi::io module stable.

4b3a5fa

update doc links

2b458fe

lyming2007 closed this Oct 21, 2022

Uh oh!

Conversation

lyming2007 commented Oct 12, 2022

Uh oh!

rust-highfive commented Oct 12, 2022

Uh oh!

This comment has been minimized.

compiler-errors commented Oct 13, 2022

Uh oh!

compiler-errors commented Oct 13, 2022

Uh oh!

lyming2007 commented Oct 13, 2022

Uh oh!

compiler-errors commented Oct 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lyming2007 commented Oct 13, 2022

Uh oh!

nagisa commented Oct 18, 2022

Uh oh!

bors commented Oct 21, 2022

Uh oh!

rustbot commented Oct 21, 2022

Uh oh!

compiler-errors commented Oct 21, 2022

Uh oh!

lyming2007 commented Oct 21, 2022

Uh oh!

lyming2007 commented Oct 21, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

compiler-errors commented Oct 13, 2022 •

edited

Loading