Format dyn Trait better in type_name intrinsic#103774
Conversation
|
r? @eholk (rustbot has picked a reviewer for you, use r? to override) |
|
Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri |
src/test/ui/consts/dyn-type-name.rs
Outdated
There was a problem hiding this comment.
This isn't really testing anything about const is it?
This doesn't even need a ui test, so library/core/tests/any.rs might be a better location.
|
Looks good to me, but I like @RalfJung's suggestion to move the test to a unit test, so I'll hold off on approving it to give you a chance to make that change. Feel free to r=me once done. |
|
☔ The latest upstream changes (presumably #103829) made this pull request unmergeable. Please resolve the merge conflicts. |
9979a8c to
6f35b4b
Compare
|
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
6f35b4b to
a80b38d
Compare
This comment has been minimized.
This comment has been minimized.
a80b38d to
59ab106
Compare
This comment has been minimized.
This comment has been minimized.
59ab106 to
e24df27
Compare
|
@bors r=eholk |
Rollup of 7 pull requests Successful merges: - rust-lang#103275 (Update tinystr) - rust-lang#103703 (Gate some parser recovery behind the check) - rust-lang#103774 (Format `dyn Trait` better in `type_name` intrinsic) - rust-lang#103807 (Add tracking issue for `string_extend_from_within`) - rust-lang#103855 (rustdoc: simplify mobile item-table CSS) - rust-lang#103862 (Use `ObligationCtxt` in `fully_normalize`) - rust-lang#103864 (Reorder `walk_` functions in intravisit.rs) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Noticed this in #103764 (though not related to that PR at all!)
Just reuse
pretty_print_dyn_existentialwhich already makes an attempt to make its output stable.