Don't silently eat label before block in block-like expr#103986
Merged
bors merged 1 commit intorust-lang:masterfrom Nov 7, 2022
Merged
Don't silently eat label before block in block-like expr#103986bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
Collaborator
|
r? @lcnr (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
Contributor
Author
|
Beta nominating bc this is a pretty simple fix, and this is a strange parse that should be removed as quickly as possible. Also stable nominating, because why not (in case we ever need to make 1.65.1, this could easily be folded in) -- but I don't think this should warrant a point release. |
compiler-errors
added
beta-nominated
This comment has been minimized.
This comment has been minimized.
compiler-errors
force-pushed
the
oh-no-bad-block-should-not-have-label
branch
from
30884ad to
4e7fc66
Compare
Member
|
In #50045 I have added |
Contributor
Author
|
@est31, so the root-cause of this specific regression is that we eat |
Contributor
|
@bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 7, 2022
Rollup of 6 pull requests Successful merges: - rust-lang#103757 (Mention const and lifetime parameters in error E0207) - rust-lang#103986 (Don't silently eat label before block in block-like expr) - rust-lang#104003 (Move some tests to more reasonable directories) - rust-lang#104038 (Normalize types when deducing closure signature from supertraits) - rust-lang#104052 (Fix `resolution_failure` ICE) - rust-lang#104090 (Modify comment syntax error) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Contributor
|
@rustbot label beta-accepted |
rustbot
added
the
beta-accepted
Contributor
|
and stable backport declined @rustbot label -stable-nominated |
rustbot
removed
the
stable-nominated
Mark-Simulacrum
removed
the
beta-nominated
Merged
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 20, 2022
…mulacrum [beta] backport * Use nominal_obligations_without_const in wf for FnDef rust-lang#104180 * Don't silently eat label before block in block-like expr rust-lang#103986 * Revert "Update CI to use Android NDK r25b" rust-lang#104628 * rustdoc: Resolve doc links in external traits having local impls rust-lang#104364 * Use 64 bits for incremental cache in-file positions rust-lang#104164 * rustdoc: Do not add external traits to the crate in register_res rust-lang#103649 * Revert "Normalize opaques with escaping bound vars" rust-lang#103509 * Bump to released stable compiler * [beta] Update cargo rust-lang#104486 r? `@Mark-Simulacrum`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #103983
cc #92823 (where the regression was introduced)