Skip to content

Skip no_mangle if the item has no name.#109347

Merged
bors merged 2 commits intorust-lang:masterfrom
cjgillot:issue-109305
Mar 31, 2023
Merged

Skip no_mangle if the item has no name.#109347
bors merged 2 commits intorust-lang:masterfrom
cjgillot:issue-109305

Conversation

@cjgillot
Copy link
Contributor

@cjgillot cjgillot commented Mar 19, 2023

Fixes #109305

@rustbot
Copy link
Collaborator

rustbot commented Mar 19, 2023

r? @WaffleLapkin

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 19, 2023
Noratrieb
Noratrieb reviewed Mar 19, 2023
View reviewed changes
@WaffleLapkin WaffleLapkin added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 20, 2023
@bors
Copy link
Collaborator

bors commented Mar 27, 2023

☔ The latest upstream changes (presumably #109091) made this pull request unmergeable. Please resolve the merge conflicts.

WaffleLapkin
WaffleLapkin approved these changes Mar 27, 2023
View reviewed changes
Copy link
Member

@WaffleLapkin WaffleLapkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the message of the first commit to better describe what it does (the matches were already introduced...)? r=me with that

@WaffleLapkin
Copy link
Member

WaffleLapkin commented Mar 28, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 28, 2023

📌 Commit 3102722 has been approved by WaffleLapkin

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 28, 2023
@bors
Copy link
Collaborator

bors commented Mar 30, 2023

⌛ Testing commit 3102722 with merge f5b96422afede88022bdd4b9dcb2ca82617d4a28...

@rust-log-analyzer
Copy link
Collaborator

rust-log-analyzer commented Mar 30, 2023

The job armhf-gnu failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
curl: (56) OpenSSL SSL_read: Connection reset by peer, errno 104

error: failed to download llvm from ci

    help: old builds get deleted after a certain time
    help: if trying to compile an old commit of rustc, disable `download-ci-llvm` in config.toml:

    [llvm]
    download-ci-llvm = false
Build completed unsuccessfully in 0:00:33

@bors
Copy link
Collaborator

bors commented Mar 30, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 30, 2023
@WaffleLapkin
Copy link
Member

WaffleLapkin commented Mar 30, 2023

curl: (56) OpenSSL SSL_read: Connection reset by peer, errno 104

@bors retry SSL error is unlikely to be caused by this PR

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 30, 2023
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Mar 30, 2023
@Dylan-DPC
Rollup merge of rust-lang#109347 - cjgillot:issue-109305, r=WaffleLapkin
5f6f30a 
Skip no_mangle if the item has no name.

Fixes rust-lang#109305
@Dylan-DPC Dylan-DPC mentioned this pull request Mar 30, 2023
Closed
@compiler-errors compiler-errors mentioned this pull request Mar 30, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 30, 2023
@bors
Auto merge of rust-lang#109791 - compiler-errors:rollup-c3o710k, r=co…
c1d3610 
…mpiler-errors

Rollup of 6 pull requests

Successful merges:

 - rust-lang#109347 (Skip no_mangle if the item has no name.)
 - rust-lang#109522 (Implement current_dll_path for AIX)
 - rust-lang#109679 (Freshen normalizes-to hack goal RHS in the evaluate loop)
 - rust-lang#109704 (resolve: Minor improvements to effective visibilities)
 - rust-lang#109739 (Closures always implement `FnOnce` in new solver)
 - rust-lang#109758 (Parallel compiler cleanups)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 987628e into rust-lang:master Mar 31, 2023
@rustbot rustbot added this to the 1.70.0 milestone Mar 31, 2023
@cjgillot cjgillot deleted the issue-109305 branch April 5, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Noratrieb Noratrieb Noratrieb left review comments

@WaffleLapkin WaffleLapkin WaffleLapkin approved these changes

Assignees

@WaffleLapkin WaffleLapkin

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.70.0

Development

Successfully merging this pull request may close these issues.

ICE: item_name: no name for DefPath, stmt_expr_attributes

6 participants

@cjgillot @rustbot @bors @WaffleLapkin @rust-log-analyzer @Noratrieb