rustdoc: fix position of default in method rendering#110765
Merged
bors merged 2 commits intorust-lang:masterfrom Jul 20, 2023
wackbyte:fix-defaultness-position
Merged
rustdoc: fix position of default in method rendering#110765bors merged 2 commits intorust-lang:masterfrom wackbyte:fix-defaultness-position
default in method rendering#110765bors merged 2 commits intorust-lang:masterfrom
wackbyte:fix-defaultness-position
Conversation
Collaborator
|
r? @jsha (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
fmease
requested changes
Jun 22, 2023
Member
fmease
left a comment
fmease
left a comment
There was a problem hiding this comment.
Thanks! Could you add a test for this though?
Collaborator
|
☔ The latest upstream changes (presumably #112957) made this pull request unmergeable. Please resolve the merge conflicts. |
fmease
reviewed
Jun 24, 2023
fmease
approved these changes
Jun 24, 2023
Member
fmease
left a comment
fmease
left a comment
There was a problem hiding this comment.
One nit, then it's good from my side at least. Thanks for adding the test cases.
fmease
approved these changes
Jun 25, 2023
GuillaumeGomez
approved these changes
Jul 20, 2023
Member
|
Nice, thanks! @bors r=fmease,GuillaumeGomez rollup |
Collaborator
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jul 20, 2023
… r=fmease,GuillaumeGomez
rustdoc: fix position of `default` in method rendering
With the following code:
```rs
#![feature(specialization)]
pub trait A {
unsafe fn a();
}
impl A for () {
default unsafe fn a() {}
}
```
rustdoc would render the `impl` of `a` as
```rs
unsafe default fn a()
```
which is inconsistent with the actual position of `default`.
This PR fixes this issue.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 20, 2023
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#110765 (rustdoc: fix position of `default` in method rendering) - rust-lang#113529 (Permit pre-evaluated constants in simd_shuffle) - rust-lang#113800 (Avoid another gha group nesting) - rust-lang#113827 (Add Foreign, Never, FnDef, Closure and Generator tys to SMIR) - rust-lang#113835 (new solver: don't consider blanket impls multiple times) - rust-lang#113883 (Remove outdated Firefox-specific CSS for search's crate selector appearance) - rust-lang#113884 (Don't translate compiler-internal bug messages) r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the following code:
rustdoc would render the
implofaaswhich is inconsistent with the actual position of
default.This PR fixes this issue.