Revert #109075 to partially fix #114375#114988
Closed
joboet wants to merge 3 commits intorust-lang:masterfrom
Closed
Revert #109075 to partially fix #114375#114988joboet wants to merge 3 commits intorust-lang:masterfrom
joboet wants to merge 3 commits intorust-lang:masterfrom
Conversation
Collaborator
|
r? @thomcc (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
Member
|
Do you have any objections to adding a test like #114375 (comment) with -Zvalidate-mir, or is this too specific? |
Member
Author
I think that's too specific, the old version does not use any special features like TAIT, so there should be no reason for the compiler to generate broken MIR. |
Member
Author
|
Closing in favour of #115005. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert #109075 so that using
Backtracedoes not cause the ICE described in #114375. Once TAIT is in a better state, I'll reapply the PR.