Ignore blank lines in response files#116610
Closed
P1n3appl3 wants to merge 1 commit intorust-lang:masterfrom
Closed
Ignore blank lines in response files#116610P1n3appl3 wants to merge 1 commit intorust-lang:masterfrom
P1n3appl3 wants to merge 1 commit intorust-lang:masterfrom
Conversation
Collaborator
|
r? @wesleywiser (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
fangism
reviewed
Oct 10, 2023
fangism
approved these changes
Oct 10, 2023
fangism
left a comment
fangism
left a comment
There was a problem hiding this comment.
Thanks for working on this! The fix looks so clean.
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
Closed in favor of #116954 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also trims whitespace from response file lines which previously caused failures.
Fixes #116068
I'm not sure where the test should go,
x.pyyelled at me for trying to add it totests/uiand none of the sub-directories seem super related. is there somewhere specifically for testing arg parsing and/orrustc_driver?