Only call mir_const_qualif if absolutely necessary

[oli-obk]

Pull the perf change out of #113617

This should not have any impact on behaviour (if it does, we'll see an ICE)

[rustbot]

r? @petrochenkov

(rustbot has picked a reviewer for you, use r? to override)

[oli-obk]

@bors try @rust-timer queue

[bors]

⌛ Trying commit c6ca2b2 with merge 9e251f9...

[rustbot]

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

[oli-obk]

@bors try @rust-timer queue

[bors]

⌛ Trying commit 57d6a6f with merge dd742c9...

[bors]

☀️ Try build successful - checks-actions
Build commit: dd742c9 (dd742c9ea5cf32b15da9747fd7523bba67c9189c)

[rust-timer]

Finished benchmarking commit (dd742c9): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.3%	[-0.5%, -0.2%]	34
Improvements ✅ (secondary)	-0.4%	[-0.4%, -0.4%]	3
All ❌✅ (primary)	-0.3%	[-0.5%, -0.2%]	34

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.2%	[2.2%, 2.3%]	2
Improvements ✅ (primary)	-0.6%	[-0.7%, -0.5%]	3
Improvements ✅ (secondary)	-2.4%	[-2.8%, -2.0%]	2
All ❌✅ (primary)	-0.6%	[-0.7%, -0.5%]	3

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.5%	[3.5%, 3.5%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.0%	[-2.1%, -1.9%]	2
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: missing data
Artifact size: 304.40 MiB -> 304.44 MiB (0.02%)

[petrochenkov]

@bors r+

[bors]

📌 Commit 57d6a6f has been approved by petrochenkov

It is now in the queue for this repository.

[bors]

⌛ Testing commit 57d6a6f with merge 10143e7...

[bors]

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing 10143e7 to master...

[rust-timer]

Finished benchmarking commit (10143e7): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.3%	[-0.5%, -0.2%]	35
Improvements ✅ (secondary)	-0.4%	[-0.4%, -0.4%]	3
All ❌✅ (primary)	-0.3%	[-0.5%, -0.2%]	35

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.2%	[-1.4%, -1.1%]	2
Improvements ✅ (secondary)	-1.2%	[-1.5%, -1.0%]	3
All ❌✅ (primary)	-1.2%	[-1.4%, -1.1%]	2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.1%	[-2.8%, -1.7%]	4
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 636.748s -> 635.347s (-0.22%)
Artifact size: 304.50 MiB -> 304.54 MiB (0.01%)