Reenable effects in libcore

[fee1-dead]

With #116670, #117531, and #117171, I think we would be comfortable with re-enabling the effects feature for more testing in libcore.

r? @oli-obk
cc @fmease
cc #110395

[rustbot]

Could not assign reviewer from: oli-obk.
User(s) oli-obk are either the PR author, already assigned, or on vacation, and there are no other candidates.
Use r? to specify someone else to assign.

[rustbot]

r? @petrochenkov

(rustbot has picked a reviewer for you, use r? to override)

[petrochenkov]

@bors r+

[bors]

📌 Commit da28b30 has been approved by petrochenkov

It is now in the queue for this repository.

[bors]

⌛ Testing commit da28b30 with merge e6dade9...

[bors]

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing e6dade9 to master...

[rust-timer]

Finished benchmarking commit (e6dade9): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.2%, 0.8%]	6
Regressions ❌ (secondary)	0.6%	[0.3%, 0.8%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.3%	[-1.3%, -1.3%]	1
All ❌✅ (primary)	0.3%	[0.2%, 0.8%]	6

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.4%	[2.4%, 4.0%]	3
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.7%	[-5.1%, -2.4%]	2
Improvements ✅ (secondary)	-3.5%	[-4.0%, -2.7%]	3
All ❌✅ (primary)	0.6%	[-5.1%, 4.0%]	5

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.7%	[0.7%, 0.7%]	1
Regressions ❌ (secondary)	2.1%	[2.0%, 2.1%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.7%	[0.7%, 0.7%]	1

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.0%, 0.3%]	14
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.1%	[-0.1%, -0.1%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[-0.1%, 0.3%]	15

Bootstrap: 676.499s -> 675.975s (-0.08%)
Artifact size: 313.81 MiB -> 313.82 MiB (0.00%)

[fee1-dead]

See #114776 (comment)

@rustbot label perf-regression-triaged