Subtree update of rust-analyzer

[lnicola]

r? @ghost

[Urgau]

The job x86_64-gnu-llvm-16 failed! Check out the build log: (web) (plain)

This failure is unrelated to this PR, #118835 will fix it.

[bors]

⌛ Testing commit 3565cec with merge 830316b...

[bors]

💔 Test failed - checks-actions

[onur-ozkan]

Need (Some(Mode::ToolStd), "rust_analyzer", None) too for

rust/src/bootstrap/src/core/build_steps/tool.rs

Lines 688 to 699 in 21cce21

	fn run(self, builder: &Builder<'_>) -> Option<PathBuf> {
	let path = builder.ensure(ToolBuild {
	compiler: self.compiler,
	target: self.target,
	tool: "rust-analyzer-proc-macro-srv",
	mode: Mode::ToolStd,
	path: "src/tools/rust-analyzer/crates/proc-macro-srv-cli",
	extra_features: vec!["sysroot-abi".to_owned()],
	is_optional_tool: false,
	source_type: SourceType::InTree,
	allow_features: RustAnalyzer::ALLOW_FEATURES,
	})?;

Update:

RustAnalyzerProcMacroSrv is compiled which then uses rust_analyzer cfg. Adding (Some(Mode::Rustc), "rust_analyzer", None) should fix that.

This seems to be not needed actually. I was wrong. (Some(Mode::ToolStd), "rust_analyzer", None) fixes dist too.

So, we need

    (Some(Mode::ToolRustc), "rust_analyzer", None),
    (Some(Mode::ToolStd), "rust_analyzer", None),

in EXTRA_CHECK_CFGS

[lnicola]

@bors r+

[bors]

📌 Commit 0cc7233 has been approved by lnicola

It is now in the queue for this repository.

[lnicola]

@bors r-

@bors r+

[bors]

📌 Commit ce8d5fb has been approved by lnicola

It is now in the queue for this repository.

[bors]

⌛ Testing commit ce8d5fb with merge 5b8bc56...

[bors]

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing 5b8bc56 to master...

[rust-timer]

Finished benchmarking commit (5b8bc56): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.2%	[4.2%, 4.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 672.818s -> 673.595s (0.12%)
Artifact size: 312.29 MiB -> 312.31 MiB (0.01%)