use if cfg! instead of #[cfg]#118993
Merged
bors merged 1 commit intorust-lang:masterfrom Dec 16, 2023
Merged
Conversation
this pr is specifically for waffle because i love it <3
rustbot
added
S-waiting-on-review
Collaborator
|
Could not assign reviewer from: |
Member
|
reviewed it together with @WaffleLapkin |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 16, 2023
…kingjubilee Rollup of 6 pull requests Successful merges: - rust-lang#118523 (Add ASCII whitespace trimming functions to `&str`) - rust-lang#118851 ([std] Add xcoff in object's feature list) - rust-lang#118989 (Simplify lint decorator derive too) - rust-lang#118993 (use `if cfg!` instead of `#[cfg]`) - rust-lang#119003 (NFC: do not clone types that are copy) - rust-lang#119004 (NFC don't convert types to identical types) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 16, 2023
Rollup merge of rust-lang#118993 - jyn514:cfg-color, r=WaffleLapkin,Nilstrieb use `if cfg!` instead of `#[cfg]` this pr is specifically for waffle because i love it <3 fixes rust-lang#118756 (comment) r? `@WaffleLapkin`
jyn514
added a commit
to jyn514/triagebot
that referenced
this pull request
Dec 18, 2023
doing so leads to weird errors: > Could not assign reviewer from: jyn514. > User(s) jyn514 are either the PR author, already assigned, or on vacation, and there are no other candidates. > Use r? to specify someone else to assign. this was likely missed when transitioning from highfive to triagebot. see rust-lang/rust#118993 for an example of a bug this fixes
jyn514
added a commit
to jyn514/triagebot
that referenced
this pull request
Dec 18, 2023
doing so leads to weird errors: > Could not assign reviewer from: jyn514. > User(s) jyn514 are either the PR author, already assigned, or on vacation, and there are no other candidates. > Use r? to specify someone else to assign. this was likely missed when transitioning from highfive to triagebot. see rust-lang/rust#118993 for an example of a bug this fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pr is specifically for waffle because i love it <3
fixes #118756 (comment)
r? @WaffleLapkin