remove `hex` dependency in bootstrap by onur-ozkan · Pull Request #119020 · rust-lang/rust

onur-ozkan · 2023-12-16T18:13:39Z

First commit removes the hex dependency, as we can achieve the same output with the added function, which is very small and simple.

Second commit creates a test module for the helpers util and adds unit tests for multiple helper functions, including hex_encode.

Signed-off-by: onur-ozkan <work@onurozkan.dev>

rustbot · 2023-12-16T18:13:47Z

r? @albertlarsan68

(rustbot has picked a reviewer for you, use r? to override)

albertlarsan68

LGTM
@bors r+ rollup
Let's see if this works :)

onur-ozkan · 2023-12-16T18:19:42Z

Doesn't work, I tried that too before :)

albertlarsan68 · 2023-12-16T18:20:16Z

@bors r+ rollup
A thing to edit in old bors, and to make sure works in new bors!

bors · 2023-12-16T18:20:18Z

📌 Commit fe897ed has been approved by albertlarsan68

It is now in the queue for this repository.

onur-ozkan · 2023-12-16T18:27:16Z

@bors r-

I think this will fail due to unused import because of the unix specific test.

onur-ozkan · 2023-12-16T18:28:30Z

Fixed https://github.com/rust-lang/rust/compare/fe897ede7b0b9598cf7282c56f971a8f38d7a07c..87b5cbcb305755e6f7033670b68840076da75e79

@bors r=albertlarsan68

bors · 2023-12-16T18:28:33Z

📌 Commit 87b5cbc has been approved by albertlarsan68

It is now in the queue for this repository.

…san68 remove `hex` dependency in bootstrap First commit removes the `hex` dependency, as we can achieve the same output with the added function, which is very small and simple. Second commit creates a test module for the helpers util and adds unit tests for multiple helper functions, including `hex_encode`.

…llaumeGomez Rollup of 5 pull requests Successful merges: - rust-lang#118644 (Add test for Apple's `-weak_framework` linker argument) - rust-lang#118828 (Remove dead codes in rustc_codegen_gcc) - rust-lang#118830 (Add support for `--env` on `tracked_env::var`) - rust-lang#119001 (rustdoc-search: remove parallel searchWords array) - rust-lang#119020 (remove `hex` dependency in bootstrap) r? `@ghost` `@rustbot` modify labels: rollup

…san68 remove `hex` dependency in bootstrap First commit removes the `hex` dependency, as we can achieve the same output with the added function, which is very small and simple. Second commit creates a test module for the helpers util and adds unit tests for multiple helper functions, including `hex_encode`.

…llaumeGomez Rollup of 5 pull requests Successful merges: - rust-lang#118828 (Remove dead codes in rustc_codegen_gcc) - rust-lang#118830 (Add support for `--env` on `tracked_env::var`) - rust-lang#119001 (rustdoc-search: remove parallel searchWords array) - rust-lang#119011 (coverage: Regression test for `assert!(!false)`) - rust-lang#119020 (remove `hex` dependency in bootstrap) r? `@ghost` `@rustbot` modify labels: rollup

est31 · 2023-12-17T01:39:05Z

@bors r- failed in rollup:

error: unused import: `env`
##[error] --> src\utils\..\tests\helpers.rs:2:11
  |
2 | use std::{env, path::PathBuf};
  |
  = note: `-D unused-imports` implied by `-D warnings`
  = help: to override `-D warnings` add `#[allow(unused_imports)]`

Signed-off-by: onur-ozkan <work@onurozkan.dev>

onur-ozkan · 2023-12-17T08:04:39Z

@bors r=albertlarsan68

bors · 2023-12-17T08:04:42Z

📌 Commit 81b98a0 has been approved by albertlarsan68

It is now in the queue for this repository.

bors · 2023-12-17T14:26:58Z

⌛ Testing commit 81b98a0 with merge 3a2aa58...

bors · 2023-12-17T16:28:09Z

☀️ Test successful - checks-actions
Approved by: albertlarsan68
Pushing 3a2aa58 to master...

rust-timer · 2023-12-17T18:26:59Z

Finished benchmarking commit (3a2aa58): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.7%	[2.7%, 2.7%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.0%	[-4.0%, -4.0%]	1
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 671.333s -> 672.166s (0.12%)
Artifact size: 312.44 MiB -> 312.45 MiB (0.00%)

create helper fn hex_encode and remove hex dependency

3ea3c38

Signed-off-by: onur-ozkan <work@onurozkan.dev>

rustbot assigned albertlarsan68 Dec 16, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Dec 16, 2023

albertlarsan68 approved these changes Dec 16, 2023

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 16, 2023

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 16, 2023

onur-ozkan force-pushed the remove-hex branch from fe897ed to 87b5cbc Compare December 16, 2023 18:27

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 16, 2023

GuillaumeGomez mentioned this pull request Dec 16, 2023

Rollup of 5 pull requests #119027

Closed

GuillaumeGomez mentioned this pull request Dec 16, 2023

Rollup of 5 pull requests #119030

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 17, 2023

expand helpers tests with new test module tests/helpers

81b98a0

Signed-off-by: onur-ozkan <work@onurozkan.dev>

onur-ozkan force-pushed the remove-hex branch from 87b5cbc to 81b98a0 Compare December 17, 2023 07:31

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 17, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 17, 2023

bors merged commit 3a2aa58 into rust-lang:master Dec 17, 2023

rustbot added this to the 1.76.0 milestone Dec 17, 2023

onur-ozkan deleted the remove-hex branch October 31, 2024 15:58

Uh oh!

Conversation

onur-ozkan commented Dec 16, 2023

Uh oh!

rustbot commented Dec 16, 2023

Uh oh!

albertlarsan68 left a comment

Choose a reason for hiding this comment

Uh oh!

onur-ozkan commented Dec 16, 2023

Uh oh!

albertlarsan68 commented Dec 16, 2023

Uh oh!

bors commented Dec 16, 2023

Uh oh!

onur-ozkan commented Dec 16, 2023

Uh oh!

onur-ozkan commented Dec 16, 2023

Uh oh!

bors commented Dec 16, 2023

Uh oh!

est31 commented Dec 17, 2023

Uh oh!

onur-ozkan commented Dec 17, 2023

Uh oh!

bors commented Dec 17, 2023

Uh oh!

bors commented Dec 17, 2023

Uh oh!

bors commented Dec 17, 2023

Uh oh!

rust-timer commented Dec 17, 2023

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants