Skip to content

Expose the Freeze trait again (unstably) and forbid implementing it manually#121840

Merged
bors merged 2 commits intorust-lang:masterfrom
oli-obk:freeze
Mar 11, 2024
Merged

Expose the Freeze trait again (unstably) and forbid implementing it manually#121840
bors merged 2 commits intorust-lang:masterfrom
oli-obk:freeze

Conversation

@oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Mar 1, 2024 •
edited
Loading

non-emoji version of #121501

cc #60715

This trait is useful for generic constants (associated consts of generic traits). See the test (tests/ui/associated-consts/freeze.rs) added in this PR for a usage example. The builtin Freeze trait is the only way to do it, users cannot work around this issue.

It's also a useful trait for building some very specific abstrations, as shown by the usage by the zerocopy crate: google/zerocopy#941

cc @RalfJung

T-lang signed off on reexposing this unstably: #121501 (comment)

@rustbot
Copy link
Collaborator

rustbot commented Mar 1, 2024

r? @michaelwoerister

rustbot has assigned @michaelwoerister.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Mar 1, 2024
@rustbot
Copy link
Collaborator

rustbot commented Mar 1, 2024

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

@oli-obk oli-obk mentioned this pull request Mar 1, 2024
Closed
@michaelwoerister
Copy link
Member

michaelwoerister commented Mar 1, 2024

Looks good to me but I guess this is r? libs-api as the original PR.

@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Mar 1, 2024
This was referenced Mar 1, 2024
Open
Closed
@dtolnay dtolnay assigned dtolnay and unassigned BurntSushi Mar 9, 2024
dtolnay
dtolnay approved these changes Mar 9, 2024
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. :) I also have needed this — compiling the test case with T: Freeze removed, I recognize this error message:

error[E0492]: constants cannot refer to interior mutable data
 --> tests/ui/associated-consts/freeze.rs:9:35
  |
9 |     const VALUE_REF: &'static T = &Self::VALUE;
  |                                   ^^^^^^^^^^^^ this borrow of an interior mutable value may end up in the final value

@dtolnay
Copy link
Member

dtolnay commented Mar 9, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 9, 2024

📌 Commit 7849230 has been approved by dtolnay

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 9, 2024
jhpratt added a commit to jhpratt/rust that referenced this pull request Mar 10, 2024
@jhpratt
Rollup merge of rust-lang#121840 - oli-obk:freeze, r=dtolnay
5d75182 
Expose the Freeze trait again (unstably) and forbid implementing it manually

non-emoji version of rust-lang#121501

cc rust-lang#60715

This trait is useful for generic constants (associated consts of generic traits). See the test (`tests/ui/associated-consts/freeze.rs`) added in this PR for a usage example. The builtin `Freeze` trait is the only way to do it, users cannot work around this issue.

It's also a useful trait for building some very specific abstrations, as shown by the usage by the `zerocopy` crate: google/zerocopy#941

cc `@RalfJung`

T-lang signed off on reexposing this unstably: rust-lang#121501 (comment)
@jhpratt jhpratt mentioned this pull request Mar 10, 2024
Closed
jhpratt added a commit to jhpratt/rust that referenced this pull request Mar 11, 2024
@jhpratt
Rollup merge of rust-lang#121840 - oli-obk:freeze, r=dtolnay
61ff631 
Expose the Freeze trait again (unstably) and forbid implementing it manually

non-emoji version of rust-lang#121501

cc rust-lang#60715

This trait is useful for generic constants (associated consts of generic traits). See the test (`tests/ui/associated-consts/freeze.rs`) added in this PR for a usage example. The builtin `Freeze` trait is the only way to do it, users cannot work around this issue.

It's also a useful trait for building some very specific abstrations, as shown by the usage by the `zerocopy` crate: google/zerocopy#941

cc ``@RalfJung``

T-lang signed off on reexposing this unstably: rust-lang#121501 (comment)
@jhpratt jhpratt mentioned this pull request Mar 11, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 11, 2024
@bors
Auto merge of rust-lang#122327 - jhpratt:rollup-q311wv9, r=jhpratt
c82742e 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#121148 (Add slice::try_range)
 - rust-lang#121573 (unix_sigpipe: Add test for SIGPIPE disposition in child processes)
 - rust-lang#121633 (Win10: Use `GetSystemTimePreciseAsFileTime` directly)
 - rust-lang#121840 (Expose the Freeze trait again (unstably) and forbid implementing it manually)
 - rust-lang#121907 (skip sanity check for non-host targets in `check` builds)
 - rust-lang#122002 (std::threads: revisit stack address calculation on netbsd.)
 - rust-lang#122108 (Add `target.*.runner` configuration for targets)
 - rust-lang#122298 (RawVec::into_box: avoid unnecessary intermediate reference)

r? `@ghost`
`@rustbot` modify labels: rollup
@jhpratt jhpratt mentioned this pull request Mar 11, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 11, 2024
@bors
Auto merge of rust-lang#122331 - jhpratt:rollup-cbl8xsy, r=jhpratt
e919669 
Rollup of 9 pull requests

Successful merges:

 - rust-lang#121148 (Add slice::try_range)
 - rust-lang#121633 (Win10: Use `GetSystemTimePreciseAsFileTime` directly)
 - rust-lang#121840 (Expose the Freeze trait again (unstably) and forbid implementing it manually)
 - rust-lang#121907 (skip sanity check for non-host targets in `check` builds)
 - rust-lang#122002 (std::threads: revisit stack address calculation on netbsd.)
 - rust-lang#122108 (Add `target.*.runner` configuration for targets)
 - rust-lang#122298 (RawVec::into_box: avoid unnecessary intermediate reference)
 - rust-lang#122315 (Allow multiple `impl Into<{D,Subd}iagMessage>` parameters in a function.)
 - rust-lang#122326 (Optimize `process_heap_alloc`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 05f22c3 into rust-lang:master Mar 11, 2024
@rustbot rustbot added this to the 1.78.0 milestone Mar 11, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 11, 2024
@rust-timer
Unrolled build for rust-lang#121840
e94c1ca 
Rollup merge of rust-lang#121840 - oli-obk:freeze, r=dtolnay

Expose the Freeze trait again (unstably) and forbid implementing it manually

non-emoji version of rust-lang#121501

cc rust-lang#60715

This trait is useful for generic constants (associated consts of generic traits). See the test (`tests/ui/associated-consts/freeze.rs`) added in this PR for a usage example. The builtin `Freeze` trait is the only way to do it, users cannot work around this issue.

It's also a useful trait for building some very specific abstrations, as shown by the usage by the `zerocopy` crate: google/zerocopy#941

cc ```@RalfJung```

T-lang signed off on reexposing this unstably: rust-lang#121501 (comment)
@Enselic Enselic mentioned this pull request Mar 12, 2024
Merged
tamird added a commit to tamird/aya that referenced this pull request Mar 12, 2024
@tamird
public-api: regenerate
a2837b8 
Nightly now exposes `core::marker::Freeze`.

rust-lang/rust#121840
@tamird tamird mentioned this pull request Mar 12, 2024
Merged
tamird added a commit to aya-rs/aya that referenced this pull request Mar 12, 2024
@tamird
public-api: regenerate
c302f83 
Nightly now exposes `core::marker::Freeze`.

rust-lang/rust#121840
bjorn3 pushed a commit to bjorn3/rust that referenced this pull request Mar 16, 2024
@jhpratt
Rollup merge of rust-lang#121840 - oli-obk:freeze, r=dtolnay
221402e 
Expose the Freeze trait again (unstably) and forbid implementing it manually

non-emoji version of rust-lang#121501

cc rust-lang#60715

This trait is useful for generic constants (associated consts of generic traits). See the test (`tests/ui/associated-consts/freeze.rs`) added in this PR for a usage example. The builtin `Freeze` trait is the only way to do it, users cannot work around this issue.

It's also a useful trait for building some very specific abstrations, as shown by the usage by the `zerocopy` crate: google/zerocopy#941

cc ```@RalfJung```

T-lang signed off on reexposing this unstably: rust-lang#121501 (comment)
@jswrenn jswrenn mentioned this pull request Apr 2, 2024
Merged
@RalfJung RalfJung mentioned this pull request May 22, 2024
Open
GuillaumeGomez pushed a commit to GuillaumeGomez/rust that referenced this pull request Jul 10, 2024
@jhpratt
Rollup merge of rust-lang#121840 - oli-obk:freeze, r=dtolnay
a6202e2 
Expose the Freeze trait again (unstably) and forbid implementing it manually

non-emoji version of rust-lang#121501

cc rust-lang#60715

This trait is useful for generic constants (associated consts of generic traits). See the test (`tests/ui/associated-consts/freeze.rs`) added in this PR for a usage example. The builtin `Freeze` trait is the only way to do it, users cannot work around this issue.

It's also a useful trait for building some very specific abstrations, as shown by the usage by the `zerocopy` crate: google/zerocopy#941

cc ```@RalfJung```

T-lang signed off on reexposing this unstably: rust-lang#121501 (comment)
@jieyouxu jieyouxu added the F-freeze `#![feature(freeze)]` label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees

@dtolnay dtolnay

Labels

F-freeze `#![feature(freeze)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.78.0

Development

Successfully merging this pull request may close these issues.

7 participants

@oli-obk @rustbot @michaelwoerister @dtolnay @bors @BurntSushi @jieyouxu