Rollup of 8 pull requests by workingjubilee · Pull Request #126107 · rust-lang/rust

workingjubilee · 2024-06-07T02:48:29Z

Successful merges:

Size optimize int formatting #125606 (Size optimize int formatting)
Uplift Relate/TypeRelation into rustc_next_trait_solver #125724 (Uplift Relate/TypeRelation into rustc_next_trait_solver)
Don't warn on fields in the unreachable_pub lint #126040 (Don't warn on fields in the unreachable_pub lint )
mark binding undetermined if target name exist and not obtained #126065 (mark binding undetermined if target name exist and not obtained)
Remove same-lib-two-locations-no-panic run-make test #126098 (Remove same-lib-two-locations-no-panic run-make test)
Crate loader cleanups #126099 (Crate loader cleanups)
Revert "Disallow ambiguous attributes on expressions" on nightly #126101 (Revert "Disallow ambiguous attributes on expressions" on nightly)
Improve Docs for hir::Impl and hir::ImplItem #126103 (Improve Docs for hir::Impl and hir::ImplItem)

r? @ghost
@rustbot modify labels: rollup

This test doesn't really make any sense anymore, it became broken a long time ago.

Simplify the path operation with `join`, clarify some of the names.

…xpr-attrs, r=davidtwco" This reverts commit 57dad1d, reversing changes made to 36316df.

…iper Size optimize int formatting Let's use the new feature flag! This uses a simpler algorithm to format integers. It is slower, but also smaller. It also saves having to import the 200 byte rodata lookup table. In a test of mine this saves ~300 bytes total of a cortex-m binary that does integer formatting. For a 16KB device, that's almost 2%. Note though that for opt-level 3 the text size actually grows by 116 bytes. Still a win in total. I'm not sure why the generated code is bigger than the more fancy algo. Maybe the smaller algo lends itself more to inlining and duplicating?

Uplift `Relate`/`TypeRelation` into `rustc_next_trait_solver` For use in the new solver. This doesn't yet uplift `ObligationEmittingRelation`. r? lcnr

… r=petrochenkov Don't warn on fields in the `unreachable_pub` lint This PR restrict the `unreachable_pub` lint by not linting on `pub` fields of `pub(restricted)` structs and unions. This is done because that can quickly clutter the code for an uncertain value, in particular since the "real" visibility is defined by the parent (the struct it-self). This is meant to address one of the last concern of the `unreachable_pub` lint. r? `@petrochenkov`

mark binding undetermined if target name exist and not obtained - Fixes rust-lang#124490 - Fixes rust-lang#125013 Following up on rust-lang#124840, I think handling only `target_bindings` is sufficient. r? `@petrochenkov`

…t, r=jieyouxu Remove `same-lib-two-locations-no-panic` run-make test This test doesn't really make any sense anymore, it became broken a long time ago. r? `@jieyouxu`

…=jieyouxu Crate loader cleanups Minor cleanups I found while trying to understand how all of this works

Revert "Disallow ambiguous attributes on expressions" on nightly As discussed in [today's t-compiler meeting](https://rust-lang.zulipchat.com/#narrow/stream/238009-t-compiler.2Fmeetings/topic/.5Bweekly.5D.202024-06-06/near/443079505), this reverts PR rust-lang#124099 to fix P-critical beta regressions rust-lang#125199. r? `@wesleywiser` Opening as draft so that `@wesleywiser` and `@apiraino,` you can tell me whether you wanted: 1. a `beta-accepted` revert of rust-lang#124099 on nightly (this PR)? That will need to be backported to beta (even though rust-lang#126093 may be the last of those) 2. a revert of rust-lang#124099 on beta? 3. all of the above? I also opened rust-lang#126102, another draft PR to revert rust-lang#124099 on beta, should you choose options 2 or 3.

…mpl, r=fmease Improve Docs for `hir::Impl` and `hir::ImplItem` Based on https://rust-lang.zulipchat.com/#narrow/stream/182449-t-compiler.2Fhelp/topic/.E2.9C.94.20Difference.20between.20.60hir.3A.3AImplItem.60.20and.20.60hir.3A.3AImpl.60.3F/near/442650915 r? fmease

workingjubilee · 2024-06-07T02:48:43Z

@bors r+ rollup=never p=8

bors · 2024-06-07T02:48:45Z

📌 Commit cd4fd96 has been approved by workingjubilee

It is now in the queue for this repository.

bors · 2024-06-07T03:21:32Z

⌛ Testing commit cd4fd96 with merge a8f09d4...

…kingjubilee Rollup of 8 pull requests Successful merges: - rust-lang#125606 (Size optimize int formatting) - rust-lang#125724 (Uplift `Relate`/`TypeRelation` into `rustc_next_trait_solver`) - rust-lang#126040 (Don't warn on fields in the `unreachable_pub` lint ) - rust-lang#126065 (mark binding undetermined if target name exist and not obtained) - rust-lang#126098 (Remove `same-lib-two-locations-no-panic` run-make test) - rust-lang#126099 (Crate loader cleanups) - rust-lang#126101 (Revert "Disallow ambiguous attributes on expressions" on nightly) - rust-lang#126103 (Improve Docs for `hir::Impl` and `hir::ImplItem`) r? `@ghost` `@rustbot` modify labels: rollup

rust-log-analyzer · 2024-06-07T04:01:17Z

The job test-various failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

13 


The actual stderr differed from the expected stderr.
Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/imports/cycle-import-in-std-2/cycle-import-in-std-2.stderr
To only update this specific test, also pass `--test-args imports/cycle-import-in-std-2.rs`

error: 1 errors occurred comparing output.
status: exit status: 1
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/imports/cycle-import-in-std-2.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=wasm32-wasip1" "--check-cfg" "cfg(FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/imports/cycle-import-in-std-2" "-A" "unused" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/wasm32-wasip1/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/imports/cycle-import-in-std-2/auxiliary" "--edition=2018"
--- stderr -------------------------------
error[E0432]: unresolved import `io`
##[error]  --> /checkout/tests/ui/imports/cycle-import-in-std-2.rs:5:10
   |
---
13 


The actual stderr differed from the expected stderr.
Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/imports/cycle-import-in-std-1/cycle-import-in-std-1.stderr
To only update this specific test, also pass `--test-args imports/cycle-import-in-std-1.rs`

error: 1 errors occurred comparing output.
status: exit status: 1
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/imports/cycle-import-in-std-1.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=wasm32-wasip1" "--check-cfg" "cfg(FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/imports/cycle-import-in-std-1" "-A" "unused" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/wasm32-wasip1/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/imports/cycle-import-in-std-1/auxiliary" "--edition=2018"
--- stderr -------------------------------
error[E0432]: unresolved import `io`
##[error]  --> /checkout/tests/ui/imports/cycle-import-in-std-1.rs:5:10
   |

bors · 2024-06-07T04:01:50Z

💔 Test failed - checks-actions

diondokter and others added 20 commits May 27, 2024 11:08

Size optimize int formatting

d32d1c1

mark binding undetermined if target name exist and not obtained

9b1c304

Make middle not rely on next_trait_solver

c74efbc

Uplift TypeError

82ef3ad

Uplift TypeRelation and Relate

91274c8

Don't warn on fields in the unreachable_pub lint

89d86ae

Remove same-lib-two-locations-no-panic run-make test

a5429d5

This test doesn't really make any sense anymore, it became broken a long time ago.

Remove constant parameter from CrateLocator::new

3a02cdb

Simplify string operations in crate loader

4c2b21a

Improve naming and path operations in crate loader

b4c439c

Simplify the path operation with `join`, clarify some of the names.

Revert "Rollup merge of rust-lang#124099 - voidc:disallow-ambiguous-e…

216424d

…xpr-attrs, r=davidtwco" This reverts commit 57dad1d, reversing changes made to 36316df.

Improve Docs for hir::Impl and hir::ImplItem

cddf291

Rollup merge of rust-lang#125724 - compiler-errors:uplift-relate, r=lcnr

ee664a5

Uplift `Relate`/`TypeRelation` into `rustc_next_trait_solver` For use in the new solver. This doesn't yet uplift `ObligationEmittingRelation`. r? lcnr

Rollup merge of rust-lang#126098 - Kobzol:remove-same-lib-runmake-tes…

8ed2e52

…t, r=jieyouxu Remove `same-lib-two-locations-no-panic` run-make test This test doesn't really make any sense anymore, it became broken a long time ago. r? `@jieyouxu`

Rollup merge of rust-lang#126099 - Nilstrieb:crate-loader-cleanups, r…

37ff3dc

…=jieyouxu Crate loader cleanups Minor cleanups I found while trying to understand how all of this works

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 7, 2024

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 7, 2024

workingjubilee mentioned this pull request Jun 7, 2024

mark binding undetermined if target name exist and not obtained #126065

Merged

workingjubilee closed this Jun 7, 2024

workingjubilee deleted the rollup-0h6p5sq branch June 7, 2024 05:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 8 pull requests#126107

Rollup of 8 pull requests#126107
workingjubilee wants to merge 20 commits intorust-lang:masterfrom
workingjubilee:rollup-0h6p5sq

workingjubilee commented Jun 7, 2024

Uh oh!

workingjubilee commented Jun 7, 2024

Uh oh!

bors commented Jun 7, 2024

Uh oh!

bors commented Jun 7, 2024

Uh oh!

rust-log-analyzer commented Jun 7, 2024

Uh oh!

bors commented Jun 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

Uh oh!

Conversation

workingjubilee commented Jun 7, 2024

Uh oh!

workingjubilee commented Jun 7, 2024

Uh oh!

bors commented Jun 7, 2024

Uh oh!

bors commented Jun 7, 2024

Uh oh!

rust-log-analyzer commented Jun 7, 2024

Uh oh!

bors commented Jun 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants