Make has_attr check behind effects feature

[fee1-dead]

attempt to fix the performance regression in #120639.

cc #110395

r? project-const-traits

[fee1-dead]

@bors try @rust-timer queue

[bors]

⌛ Trying commit a1157c7 with merge 0c92609...

[compiler-errors]

r=me if perf is improved 💀

has_attr calls are notorious for causing problems with perf -- we could perhaps whether a trait is const to the TraitDef

[fee1-dead]

we could perhaps whether a trait is const to the TraitDef

good as a followup. Will do when I get time

[compiler-errors]

thanks lmao i realized i forgot a verb in that sentence -- "record" whether

[bors]

☀️ Try build successful - checks-actions
Build commit: 0c92609 (0c92609f7b1146673c3f0abd4d21faa6a5539dd8)

[rust-timer]

Finished benchmarking commit (0c92609): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 696.374s -> 697.881s (0.22%)
Artifact size: 324.63 MiB -> 324.61 MiB (-0.00%)