Rewrite and rename `issue-22131` and `issue-26006` `run-make` tests to rmake by Oneirical · Pull Request #127621 · rust-lang/rust

Oneirical · 2024-07-11T19:08:47Z

Part of #121876 and the associated Google Summer of Code project.

Please try:

try-job: x86_64-msvc
try-job: i686-mingw

rustbot · 2024-07-11T19:08:54Z

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2024-07-11T19:08:57Z

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

jieyouxu · 2024-07-11T19:17:14Z

@bors delegate+ (for try jobs only)

bors · 2024-07-11T19:17:18Z

✌️ @Oneirical, you can now approve this pull request!

If @jieyouxu told you to "r=me" after making some further change, please make that change, then do @bors r=@jieyouxu

jieyouxu · 2024-07-11T19:17:19Z

@bors try

bors · 2024-07-11T19:18:29Z

⌛ Trying commit e97266a with merge add56b1...

Rewrite and rename `issue-22131` and `issue-26006` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). Please try: try-job: x86_64-msvc try-job: test-various

bors · 2024-07-11T19:52:42Z

💔 Test failed - checks-actions

Oneirical · 2024-07-11T20:16:07Z

TIL -L cwd() is not baked into rustdoc like it is for rustc in run_make_support.

Oneirical · 2024-07-12T15:00:58Z

@bors try

Rewrite and rename `issue-22131` and `issue-26006` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). Please try: try-job: x86_64-msvc try-job: test-various

bors · 2024-07-12T15:02:09Z

⌛ Trying commit 43e1a3e with merge 3cc3da9...

bors · 2024-07-12T16:55:06Z

💔 Test failed - checks-actions

Oneirical · 2024-07-12T17:09:45Z

Ignore restored, reason added. @rustbot review

jieyouxu

Thanks, changes look good, just some minor nits.

tests/run-make/invalid-symlink-search-path/rmake.rs

tests/run-make/rustdoc-cfgspec-parsing/rmake.rs

tests/run-make/invalid-symlink-search-path/rmake.rs

jieyouxu · 2024-07-18T01:53:37Z

Tiny import path adjustment.
@rustbot author

bors · 2024-07-18T14:11:43Z

☔ The latest upstream changes (presumably #127906) made this pull request unmergeable. Please resolve the merge conflicts.

Oneirical · 2024-07-18T15:14:49Z

@rustbot ready
Rebased and fix applied.

jieyouxu · 2024-07-18T15:16:11Z

Thanks. r=me after CI is green.
@bors delegate+

bors · 2024-07-18T15:16:14Z

✌️ @Oneirical, you can now approve this pull request!

If @jieyouxu told you to "r=me" after making some further change, please make that change, then do @bors r=@jieyouxu

Oneirical · 2024-07-18T16:46:37Z

@bors r=@jieyouxu

bors · 2024-07-18T16:46:39Z

📌 Commit fc4404c has been approved by jieyouxu

It is now in the queue for this repository.

Rewrite and rename `issue-22131` and `issue-26006` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). Please try: try-job: x86_64-msvc try-job: i686-mingw

…llaumeGomez Rollup of 5 pull requests Successful merges: - rust-lang#121533 (Handle .init_array link_section specially on wasm) - rust-lang#123196 (Add Process support for UEFI) - rust-lang#127621 (Rewrite and rename `issue-22131` and `issue-26006` `run-make` tests to rmake) - rust-lang#127928 (Migrate `lto-smoke-c` and `link-path-order` `run-make` tests to rmake) - rust-lang#127935 (Change `binary_asm_labels` to only fire on x86 and x86_64) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#127350 (Parser: Suggest Placing the Return Type After Function Parameters) - rust-lang#127621 (Rewrite and rename `issue-22131` and `issue-26006` `run-make` tests to rmake) - rust-lang#127662 (When finding item gated behind a `cfg` flag, point at it) - rust-lang#127903 (`force_collect` improvements) - rust-lang#127932 (rustdoc: fix `current` class on sidebar modnav) - rust-lang#127943 (Don't allow unsafe statics outside of extern blocks) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#127621 - Oneirical:hypnotest-show, r=jieyouxu Rewrite and rename `issue-22131` and `issue-26006` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). Please try: try-job: x86_64-msvc try-job: i686-mingw

rustbot assigned jieyouxu Jul 11, 2024

jieyouxu mentioned this pull request Jul 11, 2024

Tracking Issue for porting run-make tests to use Rust #121876

Closed

This comment has been minimized.

Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 11, 2024

This comment has been minimized.

Sign in to view

Oneirical force-pushed the hypnotest-show branch from e97266a to 43e1a3e Compare July 11, 2024 20:15

This comment has been minimized.

Sign in to view

Oneirical force-pushed the hypnotest-show branch from 43e1a3e to df74076 Compare July 12, 2024 17:09

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 12, 2024

jieyouxu approved these changes Jul 14, 2024

View reviewed changes

tests/run-make/invalid-symlink-search-path/rmake.rs Outdated Show resolved Hide resolved

tests/run-make/rustdoc-cfgspec-parsing/rmake.rs Outdated Show resolved Hide resolved

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 17, 2024

This comment has been minimized.

Sign in to view

jieyouxu reviewed Jul 18, 2024

View reviewed changes

tests/run-make/invalid-symlink-search-path/rmake.rs Outdated Show resolved Hide resolved

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 18, 2024

Oneirical force-pushed the hypnotest-show branch from e280330 to ff1ad3c Compare July 18, 2024 15:13

Oneirical added 2 commits July 18, 2024 11:13

Rewrite and rename issue-22131 to rmake

9dc08e3

Rewrite and rename issue-26006 to rmake

fc4404c

Oneirical force-pushed the hypnotest-show branch from ff1ad3c to fc4404c Compare July 18, 2024 15:14

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 18, 2024

jieyouxu approved these changes Jul 18, 2024

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 18, 2024

GuillaumeGomez mentioned this pull request Jul 18, 2024

Rollup of 5 pull requests #127941

Closed

matthiaskrgr mentioned this pull request Jul 19, 2024

Rollup of 6 pull requests #127957

Merged

bors merged commit 7161e2d into rust-lang:master Jul 19, 2024

rustbot added this to the 1.81.0 milestone Jul 19, 2024

Uh oh!

Conversation

Oneirical commented Jul 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 11, 2024

Uh oh!

rustbot commented Jul 11, 2024

Uh oh!

jieyouxu commented Jul 11, 2024

Uh oh!

bors commented Jul 11, 2024

Uh oh!

jieyouxu commented Jul 11, 2024

Uh oh!

bors commented Jul 11, 2024

Uh oh!

This comment has been minimized.

bors commented Jul 11, 2024

Uh oh!

This comment has been minimized.

Oneirical commented Jul 11, 2024

Uh oh!

Oneirical commented Jul 12, 2024

Uh oh!

bors commented Jul 12, 2024

Uh oh!

This comment has been minimized.

bors commented Jul 12, 2024

Uh oh!

Oneirical commented Jul 12, 2024

Uh oh!

jieyouxu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

Uh oh!

jieyouxu commented Jul 18, 2024

Uh oh!

bors commented Jul 18, 2024

Uh oh!

Oneirical commented Jul 18, 2024

Uh oh!

jieyouxu commented Jul 18, 2024

Uh oh!

bors commented Jul 18, 2024

Uh oh!

Oneirical commented Jul 18, 2024

Uh oh!

bors commented Jul 18, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Oneirical commented Jul 11, 2024 •

edited

Loading