find_field does not need to be a query.

[cjgillot]

The current implementation is quadratic in the number of nested fields.

r? @davidtwco as you reviewed #115367
Fixes #121755

[compiler-errors]

r=me after perf

@bors try @rust-timer queue

[bors]

⌛ Trying commit b494d98 with merge 58be51f...

[bors]

☀️ Try build successful - checks-actions
Build commit: 58be51f (58be51f56221a50dc8ae15cdff3a1c7efbf8d81c)

[rust-timer]

Finished benchmarking commit (58be51f): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-7.6%	[-13.5%, -2.7%]	9
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary -2.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.6%	[2.3%, 3.2%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-6.8%	[-10.2%, -2.9%]	4
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 699.561s -> 700.029s (0.07%)
Artifact size: 328.65 MiB -> 328.60 MiB (-0.01%)

[cjgillot]

@bors r=compiler-errors

[bors]

📌 Commit b494d98 has been approved by compiler-errors

It is now in the queue for this repository.

[bors]

⌛ Testing commit b494d98 with merge 8b72d7a...

[bors]

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 8b72d7a to master...

[rust-timer]

Finished benchmarking commit (8b72d7a): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-7.5%	[-13.5%, -2.7%]	9
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (secondary -3.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.1%	[-3.1%, -3.1%]	1
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary 3.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	11.1%	[9.2%, 13.1%]	6
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-6.7%	[-9.6%, -3.6%]	5
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 701.292s -> 701.123s (-0.02%)
Artifact size: 328.63 MiB -> 328.64 MiB (0.00%)